Reconciler: skip failed or succeeded Pods in live Pod list #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xagent003
force-pushed
the
arjun/skipTerminalPods
branch
from
c22ada7 to
5b4822d
Compare
xagent003
force-pushed
the
arjun/skipTerminalPods
branch
2 times, most recently
from
81effcc to
ee6e2a3
Compare
Contributor
Author
Collaborator
|
Just introduce the changes in wrappedPod.go. Why do you need the other changes (autogenerated changes)? |
xagent003
force-pushed
the
arjun/skipTerminalPods
branch
from
ee6e2a3 to
5092956
Compare
Contributor
Author
Hi @mlguerrero12 sorry for the long delay. I undid the cherry-pick and just added the change to wrappedPod.go. Can you or @dougbtv please take a look now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs remain in Failed or Succeeded state - they are not Running nor Pending. As a result the ip-reconciler is not cleaning up their IPs.
We should consider terminal Pods as gone, and not included in the live whereabouts Pods map. This way the reconciler will clean them up