Skip to content

Conversation

@xagent003
Copy link
Contributor

@xagent003 xagent003 commented Apr 9, 2025

A few optimization fixes:

  • return if leader election fails
  • no need for the costly list IPpools call at start of each IPAM to "test" API server connectivity. We get the IPpools anyways and use client-go leader election.
  • refactored the isOrphanedIP loop in reconciler and also noticed the logic was backwards for the return value. Fixed that and we can just do a map lookup rather the iterate through the entire livePod list which can be huge

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14346079613

Details

  • 33 of 44 (75.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 51.559%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/storage/kubernetes/ipam.go 0 3 0.0%
pkg/reconciler/iploop.go 33 41 80.49%
Files with Coverage Reduction New Missed Lines %
pkg/reconciler/iploop.go 2 71.43%
Totals Coverage Status
Change from base Build 14267829069: 0.04%
Covered Lines: 1968
Relevant Lines: 3817

💛 - Coveralls

@xagent003 xagent003 changed the title Arjun/wboptimization Reconciler and status check optimizations Apr 9, 2025
@xagent003
Copy link
Contributor Author

@dougbtv @maiqueb Can you please take a look?

Copy link
Collaborator

@mlguerrero12 mlguerrero12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @xagent003, posted some comments

@xagent003 xagent003 force-pushed the arjun/wboptimization branch from 161d27b to 849ddfe Compare July 25, 2025 05:47
@xagent003
Copy link
Contributor Author

@mlguerrero12 Sorry for the long delay on this one as well. Updated the PR per your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants