Skip to content

Conversation

@thomasferrandiz
Copy link
Collaborator

  • Align the chart with the daemonset manifest
  • Fix source command in scripts: In busybox-based images, source does not look in the current directory so an absolute path is needed.
    What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer (optional):

In busybox-based images, source does not look in the current directory so an absolute path is needed.
@coveralls
Copy link

coveralls commented Apr 23, 2025

Pull Request Test Coverage Report for Build 14643628862

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.519%

Totals Coverage Status
Change from base Build 14643011899: 0.0%
Covered Lines: 1967
Relevant Lines: 3818

💛 - Coveralls

@mlguerrero12
Copy link
Collaborator

is the deployment with helm charts failing without the /lib? It uses the same image

@thomasferrandiz
Copy link
Collaborator Author

No the chart just needed an update to be aligned with the standard manifest.

The /lib change is to fix is an issue when repackaging downstream using a busybox-based image.
The source command included with busybox needs an absolute path to work properly.

@mlguerrero12
Copy link
Collaborator

yes, we forgot to also change the daemonset in the charts when we modified the one under the doc dir. We should have a comment in both files to not forget next time.

I see, so, it is for repacking downstream. LGTM

Would you mind adding the comment I mentioned?

@mlguerrero12 mlguerrero12 merged commit bccf0ba into k8snetworkplumbingwg:master Apr 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants