Add priorityClassName support to Helm chart #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure we can mark daemonsets pods as first priority to be scheduled before the apps we need to support `priorityClassName` field. By default, it won't be added.
thomasferrandiz
approved these changes
May 28, 2025
Author
|
Hmm, the failed test doesn't seem related to my changes. |
Author
|
Great, it has passed. |
thomasferrandiz
approved these changes
Jun 3, 2025
Author
|
@thomasferrandiz can we merge it? |
mlguerrero12
merged commit ccd5a4c
into
k8snetworkplumbingwg:master
11 of 12 checks passed
|
@mlguerrero12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To make sure we can mark daemonsets pods as first priority to be scheduled before the apps we need to support
priorityClassNamefield.By default, it won't be added.