make reconciler process default iface#644
Open
miminar wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Open
make reconciler process default iface#644miminar wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
miminar wants to merge 1 commit intok8snetworkplumbingwg:masterfrom
Conversation
Signed-off-by: Michal Minář <michal.minar@id.ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow whereabouts to be used for the default interface (e.g. when a pod/VM does not reside on the pod network).
What this PR does / why we need it:
To support a use-case when it is not desirable to expose a pod/VM on the pod network.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #638
Special notes for your reviewer (optional):
Pod reconciler used to ignore the default iface, which led to garbage collection of valid IPs. With this change it considers any network referencing a net-attach-dev and relies on the fact that the network name in
network-statusis set to$namespace/$nameIf there's a use-case where whereabouts needs to used without multus, then this will need to be reworked. Please let me know.