Add PullSecret string field for the Image instead of PullSecretRef#1623
Open
burmanm wants to merge 1 commit intok8ssandra:mainfrom
Open
Add PullSecret string field for the Image instead of PullSecretRef#1623burmanm wants to merge 1 commit intok8ssandra:mainfrom
burmanm wants to merge 1 commit intok8ssandra:mainfrom
Conversation
… per Kubernetes direction
|
No linked issues found. Please add the corresponding issues in the pull request description. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds "PullSecret" to the Image struct that has precedence over PullSecretRef. This is to ensure the compatibility with the cass-operator Image type (and to allow easier migration in the future) and adheres to the API documentation in Kubernetes which states for LocalObjectReference:
"// New uses of this type are discouraged because of difficulty describing its usage when embedded in APIs."
Also, deprecate PullSecretRef so we can in the future migrate away from it.
Which issue(s) this PR fixes:
Fixes #
Checklist