fix: Move @types packages to devDependencies#193
Conversation
Move type definition packages from dependencies to devDependencies as they are only needed at build time, not runtime. Fixes kOaDT#79 These packages were incorrectly listed in dependencies: - @types/canvas-confetti - @types/jsonwebtoken
|
Welcome @TrivCodez, and thank you for your first contribution to the project! 🎉 📊 PR overview
📝 Before reviewTo help maintainers review your changes efficiently, please ensure that:
✅ Continuous IntegrationTwo CI workflows will run automatically on this PR:
You can follow their progress in the Checks tab. 🤝 A note on collaborationWe value respectful and constructive interactions. Whether you are a contributor or a reviewer, please be patient, kind, and open to feedback. A maintainer will review your changes as soon as possible. If you have any questions, feel free to ask in this thread. |
kOaDT
left a comment
There was a problem hiding this comment.
Thanks a lot @TrivCodez for your PR! Looks good to me, merging it in.
I pushed a small commit on top of your branch to add a trailing newline at the end of package.json otherwise the format check in CI was failing.
Feel free to contribute again anytime, it's much appreciated!
What
Move type definition packages from dependencies to devDependencies as they are only needed at build time, not runtime.
Why
@types/canvas-confettiand@types/jsonwebtokenare type definition packages that should be in devDependenciesChanges
@types/canvas-confettiand@types/jsonwebtokenfromdependenciestodevDependenciesTesting
npm run buildstill works (as per issue acceptance criteria)Notes
Fixes #79
These packages were incorrectly listed in the dependencies section. Type definitions only provide compile-time information and should not be included in production bundles.