Skip to content

fix: Move @types packages to devDependencies#193

Merged
kOaDT merged 2 commits intokOaDT:mainfrom
TrivCodez:fix/move-types-to-dev
Apr 26, 2026
Merged

fix: Move @types packages to devDependencies#193
kOaDT merged 2 commits intokOaDT:mainfrom
TrivCodez:fix/move-types-to-dev

Conversation

@TrivCodez
Copy link
Copy Markdown
Contributor

What

Move type definition packages from dependencies to devDependencies as they are only needed at build time, not runtime.

Why

  • @types/canvas-confetti and @types/jsonwebtoken are type definition packages that should be in devDependencies
  • These packages are only required during TypeScript compilation, not at runtime
  • Proper dependency categorization reduces production bundle size

Changes

  • package.json: Moved @types/canvas-confetti and @types/jsonwebtoken from dependencies to devDependencies

Testing

  • Verified npm run build still works (as per issue acceptance criteria)
  • Build completes successfully
  • All TypeScript typings remain functional

Notes

Fixes #79

These packages were incorrectly listed in the dependencies section. Type definitions only provide compile-time information and should not be included in production bundles.

Move type definition packages from dependencies to devDependencies as they are only needed at build time, not runtime.
Fixes kOaDT#79

These packages were incorrectly listed in dependencies:
- @types/canvas-confetti
- @types/jsonwebtoken
@github-actions
Copy link
Copy Markdown

Welcome @TrivCodez, and thank you for your first contribution to the project! 🎉

📊 PR overview

Files changed Additions Deletions Size
1 +3 -3 XS

📝 Before review

To help maintainers review your changes efficiently, please ensure that:

  • The PR description clearly explains what was changed and why
  • The PR checklist has been filled out
  • All existing tests continue to pass
  • New tests have been added for any new functionality

📖 Please review our Contributing Guidelines and Code of Conduct.

✅ Continuous Integration

Two CI workflows will run automatically on this PR:

  • Code Quality — linting and formatting checks
  • Exploitation Tests — ensures vulnerabilities and flags work as expected

You can follow their progress in the Checks tab.

🤝 A note on collaboration

We value respectful and constructive interactions. Whether you are a contributor or a reviewer, please be patient, kind, and open to feedback.


A maintainer will review your changes as soon as possible. If you have any questions, feel free to ask in this thread.

kOaDT

@github-actions github-actions Bot added the size/XS PR size: XS label Apr 26, 2026
@kOaDT kOaDT self-assigned this Apr 26, 2026
Copy link
Copy Markdown
Owner

@kOaDT kOaDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @TrivCodez for your PR! Looks good to me, merging it in.

I pushed a small commit on top of your branch to add a trailing newline at the end of package.json otherwise the format check in CI was failing.

Feel free to contribute again anytime, it's much appreciated!

@kOaDT kOaDT merged commit 67ff5a8 into kOaDT:main Apr 26, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move @types/canvas-confetti and @types/jsonwebtoken to devDependencies

2 participants