feat: add contributors section to Hall of Fame#235
Merged
Conversation
|
Thank you @kOaDT for contributing once again! 📊 PR overview
📝 Before reviewTo help maintainers review your changes efficiently, please ensure that:
✅ Continuous IntegrationTwo CI workflows will run automatically on this PR:
You can follow their progress in the Checks tab. 🤝 A note on collaborationWe value respectful and constructive interactions. Whether you are a contributor or a reviewer, please be patient, kind, and open to feedback. A maintainer will review your changes as soon as possible. If you have any questions, feel free to ask in this thread. |
Display project contributors alongside players on the Hall of Fame page. Contributors are fetched from the GitHub API at build time. Also centralize the repo URL: lib/config now exposes GITHUB_REPO_SLUG and derives GITHUB_REPO from it, and all hardcoded repo URLs across the app now import from it (DRY).
fc19077 to
1756124
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Display project contributors alongside players on the Hall of Fame page, splitting it into two groups on the same page:
hall-of-fame/data.json.process.envof a deliberately vulnerable app (file-read / RCE challenges could exfiltrate it). Unauthenticated is enough given the ~1 request/day caused by ISR. The section is hidden if the fetch fails, so the page never breaks.The "Join the Hall of Fame" CTA stays grouped with the players, and the contributors grid reuses the same hover animation as the player cards for visual consistency.
Also centralizes the repo URL:
lib/confignow exposesGITHUB_REPO_SLUGand derivesGITHUB_REPOfrom it. All hardcoded repo URLs across the app (Footer,PlayerDashboardClient,FlagChecker,hall-of-fame/page,contact/page,SupportBanner) now import from it (DRY). The duplicatedTrophyIcon/GitHubIconSVGs were extracted to a sharedapp/hall-of-fame/icons.tsx.Type of change
Testing done
npx tsc --noEmitpasses with no errors.Checklist
If adding a new vulnerability
prisma/seed.tswith formatOSS{...}prisma/seed.tscontent/vulnerabilities/(concept + fix only — no exploit steps, payloads, or flag value)docs/src/data/blog/,walkthroughSlugis set on the flag inprisma/seed.ts