Fix broken JS SDK code snippets (invalid syntax, missing imports, undefined variables)

[kaankacar]

Context

An audit of JS SDK content across the docs found snippets that fail if copied as written. Each item below is a concrete fix with an exact location. These are copy-paste bugs, not API staleness; the surrounding pages are otherwise current.

Checklist

docs/data/apis/horizon/api-reference/errors/error-handling.mdx

• Line 69: let server = sdk.Server("https://horizon-testnet.stellar.org"); uses the pre-v10 constructor without new and without the Horizon namespace. Change to let server = new sdk.Horizon.Server("https://horizon-testnet.stellar.org");
• Line 97: time.sleep(5 * time.Second); is Go code inside a JS block. Replace with await new Promise((resolve) => setTimeout(resolve, 5000));
• Line 138: let server = Horizon.Server(...) is missing new. Also normalize the inconsistent sdk. vs StellarSdk. naming across the page's snippets.
• While in the file, cross-link the SDK error handling guide: https://stellar.github.io/js-stellar-sdk/guides/05-handle-errors/

docs/learn/fundamentals/contract-development/contract-interactions/stellar-transaction.mdx

• Line 48: rpc as StellarRpc appears inside a CommonJS require() destructure. as aliasing is import-statement syntax; in a destructure it must be rpc: StellarRpc (or convert the block to an ESM import).

docs/learn/fundamentals/contract-development/contract-interactions/transaction-simulation.mdx

• Line 75 and line 129: const s = Server("https://soroban-testnet.stellar.org"); is missing new.
• The snippets use BASE_FEE, nativeToScVal, and Address without importing them. Add them to the import statements.

docs/tokens/how-to-issue-an-asset.mdx

• Line 118: the secret key is wrapped in curly quotes (‘...’), which is a syntax error if copied. Replace with straight quotes.
• Early snippets on the page use a global StellarSdk with no import shown; add the import * as StellarSdk from "stellar/stellar-sdk"; line (the full sample at the bottom already has it).

docs/build/guides/transactions/path-payments.mdx

• Line 77: await SERVER.submitTransaction(transaction) references an undefined SERVER. Use the Horizon server variable defined earlier in the snippet.

docs/data/apis/rpc/api-reference/methods/getLedgerEntries.mdx

• Line 387: const s = new Server(...) with no import shown and no namespace. Show import { Server } from "stellar/stellar-sdk/rpc"; (and the AssetType import used nearby).

Secondary (undefined variables, verify while in the file)

• docs/build/guides/basics/automate-reset-data.mdx line 180: networkPassPhrase is never defined (casing mismatch); line 264: returnContractResponse is never defined. The script also uses Asset and nativeToScVal without importing them.
• docs/build/guides/transactions/submit-transaction-wait-js.mdx line 36: throw tmpStatus; references an undefined variable. Note this page defines the shared submitTx helper reused by several other guides, so fix carefully.
• docs/build/guides/archival/restore-contract-js.mdx line 69: function getWasmLedgerKey(entry: xdr.ContractDataEntry): { has an empty return type annotation (syntax error), and the file uses xdr.* without importing xdr.

Acceptance criteria

• Every JS/TS snippet touched parses (paste into a TS playground or run npx tsc --noEmit on extracted snippets).
• No JS block contains non-JS code.

---

Demo copy of stellar#2562 (original author: oceans404) — seeded for the triage-agent demo; content unchanged apart from neutralized mentions.

[claude]

Checked: dedupe search across open/closed issues and PRs, then verified every line-numbered claim against the current main checkout (each file below exists and was read directly, not via the issue's blob links).

Evidence (all confirmed against current main):

• docs/data/apis/horizon/api-reference/errors/error-handling.mdx:69 — let server = sdk.Server(...) (no new, no Horizon namespace); :97 — time.sleep(5 * time.Second); inside a js block; :138 — let server = Horizon.Server(...) (missing new).
• docs/learn/fundamentals/contract-development/contract-interactions/stellar-transaction.mdx:48 — rpc as StellarRpc inside a require() destructure (invalid outside ESM import syntax).
• docs/learn/fundamentals/contract-development/contract-interactions/transaction-simulation.mdx:75,129 — const s = Server(...) missing new; BASE_FEE/nativeToScVal/Address used without import.
• docs/tokens/how-to-issue-an-asset.mdx:118 — secret key wrapped in curly quotes; earlier snippets use a global StellarSdk with no import shown.
• docs/build/guides/transactions/path-payments.mdx:77 — SERVER.submitTransaction(...) references an undefined SERVER (the snippet defines horizonServer).
• docs/data/apis/rpc/api-reference/methods/getLedgerEntries.mdx:387 — const s = new Server(...) with no import/namespace shown.
• docs/build/guides/basics/automate-reset-data.mdx:79 defines networkPassphrase, but :180 uses networkPassPhrase (casing mismatch, ReferenceError); :264 uses returnContractResponse, which is never defined (only status and later returnInvokeContractResponse exist); Asset and nativeToScVal (used lines 275/314/319) are absent from the import block at lines 51-62.
• docs/build/guides/transactions/submit-transaction-wait-js.mdx:36 — throw tmpStatus; is undefined in scope (only reply/finalStatus exist).
• docs/build/guides/archival/restore-contract-js.mdx:69 — empty return-type annotation (syntax error); xdr is used but never imported.

Dedupe: no exact duplicate or resolving PR found. #16/#15/#18 touch nearby JS-SDK docs but address different problems (insecure links, cross-linking, and a section rewrite respectively), not these copy-paste snippet defects.

Conclusion: confirmed-valid — every checklist item reproduces against current main; labeled bug + P1 per the rubric (wrong/broken code samples, user-breaking on copy-paste). Left unlabeled for area since the fixes span horizon, rpc, tokens, and build-guide docs with no single clear owner area.