Skip to content

Fix broken py-stellar-base imports in Hardhat migration example - #23

Merged
github-actions[bot] merged 1 commit into
mainfrom
fix-py-soroban-imports
Jul 16, 2026
Merged

Fix broken py-stellar-base imports in Hardhat migration example#23
github-actions[bot] merged 1 commit into
mainfrom
fix-py-soroban-imports

Conversation

@kaankacar

Copy link
Copy Markdown
Owner

SorobanServer is importable from the top-level stellar_sdk package; the nested stellar_sdk.soroban import paths are stale and break the example. Also drops the now-unused TransactionStatus import.

Mirrors upstream stellar#2545. (Demo PR for the reviewer→executor flow.)

@github-actions

Copy link
Copy Markdown

🤖 Claude docs review

Verdict: ready-for-human-approval — small, correct, complete; proposing auto-merge-candidate.

Mechanics:

  • ✓ Mergeable, no conflicts (mergeStateStatus: UNSTABLE only reflects checks still in progress at review time — nothing failing)
  • ✓ Scope: 1 file, +1/−2 lines, no build/config files, no new dependencies

Technical accuracy:

  • docs/learn/migrate/evm/smart-contract-deployment.mdx:102-103 — verified against StellarCN/py-stellar-base (current main / latest release v15.0.0): there is no stellar_sdk.soroban subpackage in the SDK — only flat modules (soroban_server.py, soroban_rpc.py, etc.). stellar_sdk/__init__.py does from .soroban_server import *, and soroban_server.py sets __all__ = ["Durability", "SorobanServer"]. So the old from stellar_sdk.soroban import SorobanServer / from stellar_sdk.soroban.soroban_rpc import TransactionStatus paths are indeed stale, and from stellar_sdk import SorobanServer is the correct top-level import.
  • ✓ Dropped TransactionStatus import is not referenced anywhere else in this file — safe to remove, not a silent behavior change.
  • ✓ Confirmed no other instance of the broken nested stellar_sdk.soroban(.soroban_rpc) pattern remains in docs/ — this fix fully resolves the defect it targets. (Other docs files use stellar_sdk.soroban_rpc, a different, still-valid flat-module path, so they're unaffected and out of scope here.)
  • ✓ Diff is identical to the (still-open) upstream reference, [chore]sdk-examples: fix broken py-stellar-base imports stellar/stellar-docs#2545, which is consistent with an independent audit against the current SDK.

Nits: none.

@github-actions github-actions Bot added the auto-merge-candidate Trivial fix, agent-reviewed — just press merge label Jul 16, 2026
@github-actions

Copy link
Copy Markdown

🤖 Docs review (agentic-workflow variant)

Verdict: trivial-auto-merge-candidate — Small import-path fix (3 lines, 1 file), no structural changes, mdx-format check passed.


Evidence

  • docs/learn/migrate/evm/smart-contract-deployment.mdx:101 — current main has from stellar_sdk.soroban import SorobanServer (stale nested path).
  • docs/learn/migrate/evm/smart-contract-deployment.mdx:102 — current main has from stellar_sdk.soroban.soroban_rpc import TransactionStatus (stale path).
  • PR replaces both with from stellar_sdk import SorobanServer (docs/learn/migrate/evm/smart-contract-deployment.mdx:101 after change).
  • TransactionStatus appears exactly once in the file (the import line only) — dropping it is safe; it is not referenced in the code body. ✅
  • SorobanServer is available from the top-level stellar_sdk package per upstream SDK. ✅

Checks

Check Status
mdx-format ✅ passed
build / build ⏳ in-progress at review time

Nits (non-blocking)

  • The PR description mentions "Hardhat migration example" but the file title is "Smart Contract Development with Soroban and Hardhat" — minor wording mismatch, not a blocker.
  • Consider whether TransactionStatus removal should be noted in the file's inline comments if any downstream reader copies the snippet (currently there are no such comments, so no change needed).

Sequencing

No dependencies on other open PRs. Can merge independently.

Generated by Docs PR review agent for #23 · 23.3 AIC · ⌖ 5.51 AIC · ⊞ 4.8K ·

@github-actions

Copy link
Copy Markdown

🤖 Agent executor: merging — carries auto-merge-candidate, is mergeable, has no changes-requested review, and every check is green.

@github-actions
github-actions Bot merged commit ce7c68f into main Jul 16, 2026
10 checks passed
@github-actions
github-actions Bot deleted the fix-py-soroban-imports branch July 16, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-candidate Trivial fix, agent-reviewed — just press merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant