AGILE-3713: Design endpoint listing by filter ID message schemas in 20/EFMP #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewPasika
changed the title
Contributor
PavelAnikeichyk
left a comment
PavelAnikeichyk
left a comment
There was a problem hiding this comment.
Maybe it could be better to use italic text style or some other text style to highlight the type of response message in this sentence:
"Repository MUST publish endpoint list by filter response message using the following NATS subject".
And it could be good to use the same style to highlight request/response types in other places.
0020/README.md
Outdated
| kaa.v1.replica.{client-service-replica-id}.efmp.ep-list-by-filter-request | ||
| ``` | ||
|
|
||
| Endpoint filters request message payload MUST be an [Avro-encoded](https://avro.apache.org/) object with the following schema ([0020-endpoint-list-by-filter-request.avsc](./0020-endpoint-list-by-filter-request.avsc)): |
Contributor
There was a problem hiding this comment.
Change request message type to "Endpoint list by filter"
0020/README.md
Outdated
| *Endpoint list by filter response* message MUST be sent by repository in response to an [endpoint list by filter request](#endpoint-list-by-filter-request). | ||
| Repository MUST publish endpoint list by filter response message to the subject provided in the NATS `replyTo` field of the request. | ||
|
|
||
| Endpoint filters response message payload MUST be an Avro-encoded object with the following schema ([0020-endpoint-list-by-filter-response.avsc](./0020-endpoint-list-by-filter-response.avsc)): |
Contributor
There was a problem hiding this comment.
Change response message type to "Endpoint list by filter"
# Conflicts: # 0020/0020-endpoint-list-by-filter-response.avsc # 0020/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.