Curried bug second attempt #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removing incorrect spaing around method names and argument params.
Open
scole66
reviewed
Aug 22, 2019
| @@ -80,5 +81,8 @@ def _curried(*args, **kwargs): | |||
| if count == len(spec.args) - len(args): | |||
| return func(*args, **kwargs) | |||
|
|
|||
| return curried(partial(func, *args, **kwargs)) | |||
| para_func = partial(func, *args, **kwargs) | |||
| update_wrapper(para_func, f) | |||
There was a problem hiding this comment.
f or func?
f was the iterator variable in the function loop, above. I suspect it's not the right choice here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from pull request 74. I have closed 74 and made this new pull request
I have limited the my pep8'ing to just the func.py file, where I have made 2 separate commits. One to fix the white spacing and one to fix the unused import. (Purely to appease my OCD)
I have made a new unit test to show exactly which bit of the curried functions where not be wrapped correct by the functools when creating a decorator.
I have applied the same bugfix as before, to use the functools to fix this problem.
The test run.
I hope that covers everything from your feedback.
Thank you.