Closes #311 - Bump Spring Boot 4 by bruderj15 · Pull Request #426 · kadai-io/KadaiAdapter

bruderj15 · 2026-03-18T09:22:11Z

I basically did four things:

Migrated Jackson 2 to 3 for all non-camunda7-side running code
Migrated Spring Boot 3 to 4
Migrated Camunda 7 Test-Suite to run Camunda 7 via external Docker container instead of in-JVM Process-Engine
Collapsed Camunda 8 Multi-Tenancy tests into single new class as flakiness seemed to have gotten worse with Camunda 8.9: no more flaky (and redundant) tests

Definition of Done

The corresponding ticket is in state In Review
The corresponding ticket is attached to this Pull-Request
The commit-message-format Closes #ISSUE_ID - PROBLEM/SOLUTION
- is present as single-commit already or
- will be squashed on merge
The changes pass the SonarQubeCloud-Quality-Gate
If the documentation needs an update, following there's a link to it: Closes #188 - Java 21 & SpringBoot 4 kadai-doc#191
If extra release-notes are required, they're listed indented below:

…ava-25

… 4 variant

…ot-4 # Conflicts: # kadai-adapter-camunda8-parent/kadai-adapter-camunda-8-system-connector/src/test/java/io/kadai/adapter/systemconnector/camunda/monitoring/Camunda8CompositeHealthIntTest.java

sonarqubecloud · 2026-03-20T10:15:32Z

Quality Gate failed

Failed conditions
42.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

…ot-4 # Conflicts: # .github/workflows/continuous-integration.yml # kadai-adapter-camunda7-parent/kadai-adapter-camunda-system-connector/src/main/java/io/kadai/adapter/monitoring/Camunda7HealthIndicator.java # kadai-adapter-camunda7-parent/kadai-adapter-camunda-system-connector/src/main/java/io/kadai/adapter/monitoring/Camunda7OutboxHealthIndicator.java # kadai-adapter-camunda7-parent/kadai-adapter-camunda-system-connector/src/main/java/io/kadai/adapter/systemconnector/camunda/config/Camunda7SystemConnectorConfiguration.java # kadai-adapter-camunda7-parent/kadai-adapter-camunda-system-connector/src/test/java/io/kadai/adapter/monitoring/Camunda7HealthIndicatorTest.java # kadai-adapter-camunda7-parent/kadai-adapter-camunda-system-connector/src/test/java/io/kadai/adapter/monitoring/Camunda7OutboxHealthIndicatorTest.java # kadai-adapter-camunda8-parent/pom.xml

gitgoodjhe · 2026-06-12T08:24:45Z

        .areNotDeclaredIn(ArchitectureTest.class)
        .should()
        .haveNameMatching("^should_[A-Z][^_]+(_(For|When)_[A-Z][^_]+)?$")
+        .allowEmptyShould(true)


Why do we allow this? As far as i know this bypasses test failures if the criteria in the that() clause evaluate to zero matching classes, right? Is that the case here or why do we need this?

Yes. We need it because besides the arch-test there are no tests in the module (anymore).
CI failed before that change here: https://github.com/kadai-io/KadaiAdapter/actions/runs/25724530689/job/75533993183

Weird behavior from arch imo - they didn't use the well-known all-quantification semantics.

gitgoodjhe · 2026-06-12T08:30:15Z

  private double doubleField;
  private boolean booleanField;
-  private ProcessVariableTestObjectTwo processVariableTestObjectTwoField;
+  private List<ProcessVariableTestObjectTwo> processVariableTestObjectTwoField;


Why did you change this to a List?

Because the helper class moved.
Previously the C7 spring-boot-test copy of ProcessVariableTestObject already used List<ProcessVariableTestObjectTwo> and the tests asserted that JSON array shape.

With Camunda now running in Docker, the helper classes need to come from kadai-adapter-camunda-listener-example and are staged into the Camunda container. I changed that copy to match the old kadai-adapter-camunda-spring-boot-test test fixture and keep the existing acceptance-test payload semantics.

gitgoodjhe · 2026-06-12T08:40:03Z

-import org.springframework.boot.test.context.SpringBootTest;
-
-@SpringBootTest(classes = Camunda7SpringBootExample.class, webEnvironment = RANDOM_PORT)
-class Camunda7SpringBootExampleIntegrationTest {


Is this covered somewhere else now?

It inherently is with the acceptance-tests for C7, isn't it?

gitgoodjhe · 2026-06-12T08:41:57Z

-      <artifactId>resteasy-servlet-spring-boot-starter</artifactId>
-      <version>${version.resteasy.spring.boot}</version>
+      <groupId>org.springframework.boot</groupId>
+      <artifactId>spring-boot-starter-jersey</artifactId>


we change from resteasy to jersey? I remember jersey was creating issues some 5 years+ ago

Jersey is only used for tests and examples so we're fine either way I guess.

gitgoodjhe · 2026-06-12T09:11:50Z

+            </goals>
+          </execution>
+          <execution>
+            <id>default-jar</id>


this looks very hacky

Yeah not pretty at all, but intentional.
The C7 test suite has to copy the current reactor-built listener jar into the Camunda BPM Run container’s userlib during process-test-resources, before Maven’s normal package jar exists.
Early jar execution makes that local artifact available for container startup.

gitgoodjhe · 2026-06-12T09:25:24Z

- * This class is responsible for setting complex variables containing Objects on a camunda user
- * task.
- */
-public class ComplexProcessVariableSetter implements JavaDelegate {


all those classes you deleted aren't needed anymore?

They've been moved to kadai-adapter-camunda-listener-example

gitgoodjhe · 2026-06-12T09:30:17Z

      Map<String, Object> valueInfo = new HashMap<>();
-      valueInfo.put("serializationDataFormat", "application/json");
-      valueInfo.put("objectTypeName", processVariable.getValue().getClass());
+      if (processVariable instanceof ObjectValue) {


this is thouroughly tested? Because it changes the core logic

I reverted these changes.
They were relicts from experimentations.
Very good spot!

leantios

I looked at the C8 changes. Looks good generally. With C8.9, we have the possibility that the tests share a runtime, making the tests faster: https://docs.camunda.io/docs/apis-tools/testing/configuration/#shared-runtime. Should we integrate that here or in a different PR?

sonarqubecloud · 2026-06-17T12:59:23Z

Quality Gate failed

Failed conditions
50.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

leantios · 2026-06-19T07:30:41Z

Looks good from my side!

bruderj15 added 19 commits March 2, 2026 15:49

task413: bump java to 25

8c86984

task413: replace removed Subject funs

0ef7641

task413: align JAVA_VERSION=25 in ci

df2b421

task413: fix check-style

861083f

Merge remote-tracking branch 'origin/release/12.0.0' into task/#413-j…

a0cd3b4

…ava-25

task#413: fix unwrapping CompletionException

cbc693d

task#413: downgrade C7 java-version to 21 for compliance

53b2cd8

task#413: apply warning suggestion

d341382

task#413: remove redundant awaitility await

d4d9d30

task#413: align health-imports to breaking changes

241dcdc

task#413: migrate jackson 2 to 3

5cee242

task#413: migrate implicit usage of spring-boot-webtestclient

6acb1d9

task#413: more health-migrations

bdea102

task#413: more jackson-migrations

26614e8

task#413: even more jackson-migrations

f531a9d

task#413: bump spring boot deps to 4

6844ac5

task#311: swap camunda-spring-boot-starter for explicit spring-boot…

a02d0ff

… 4 variant

task#311: fix c7 system-connector tests

2f44bf7

Merge remote-tracking branch 'origin/master' into task/#311-spring-bo…

a5b18bf

…ot-4 # Conflicts: # kadai-adapter-camunda8-parent/kadai-adapter-camunda-8-system-connector/src/test/java/io/kadai/adapter/systemconnector/camunda/monitoring/Camunda8CompositeHealthIntTest.java

bruderj15 linked an issue Mar 18, 2026 that may be closed by this pull request

Bump to SpringBoot Version 4 #311

Open

4 tasks

bruderj15 added 2 commits March 18, 2026 11:07

task#311: temporarily skip c7 spring boot tests

2a27837

task#311: fix failing health int-test

da93fab

bruderj15 mentioned this pull request Mar 20, 2026

Bump version.spring.boot from 3.5.10 to 4.0.4 #427

Closed

task#311: bump spring boot 4.0.4

45b9f67

bruderj15 mentioned this pull request Mar 27, 2026

Bump version.spring.boot from 3.5.10 to 4.0.5 #434

Closed

bruderj15 mentioned this pull request Apr 9, 2026

Bump version.camunda8 from 8.8.21 to 8.9.0 #438

Closed

bruderj15 added 3 commits April 9, 2026 09:37

task#311: bump Camunda 8.9.0

f9258e8

task#311: resolve merge conflicts

3a2c161

bruderj15 added 2 commits May 19, 2026 11:58

task#311: remove giga flaky & redundant test pt3

f611893

task#311: collapse multi-tenancy tests into dedicated test class

5a0c44a

bruderj15 marked this pull request as ready for review May 21, 2026 14:31

bruderj15 mentioned this pull request Jun 5, 2026

Bump version.camunda8 from 8.8.21 to 8.9.6 #458

Closed

bruderj15 added 4 commits June 5, 2026 12:13

bump camunda 8.9.6

bb2d97d

bump kadai 11.3.2-SNAPSHOT

6c3e445

bump kadai 11.4.1-SNAPSHOT

5bd41ee

bump camunda 8.9.7

7ff7ff1

bruderj15 mentioned this pull request Jun 10, 2026

Bump version.camunda8 from 8.8.21 to 8.9.7 #461

Closed

bruderj15 added 2 commits June 11, 2026 15:20

bump camunda 8.9.8

c9eeeaf

bump spring boot 4.1

7d62c0b

This was referenced Jun 11, 2026

Bump version.spring.boot from 3.5.10 to 4.1.0 #462

Closed

Bump version.camunda8 from 8.8.21 to 8.9.8 #463

Closed

leantios self-requested a review June 12, 2026 07:13

gitgoodjhe requested changes Jun 12, 2026

View reviewed changes

leantios reviewed Jun 12, 2026

View reviewed changes

bruderj15 added 5 commits June 16, 2026 10:28

reuse json-mapper instead of reallocating for new one

4ff4cc2

make camunda 8 test util usage in tests private

a13be54

remove trailing lines

2c2fa5d

remove duplicate json mapper

0e54802

bump camunda 8.9.9

80305b4

bruderj15 mentioned this pull request Jun 17, 2026

Bump version.camunda8 from 8.8.21 to 8.9.9 #466

Closed

bruderj15 added 4 commits June 17, 2026 09:50

refine multi tenancy test name

40c3d12

stop ignoring all DbCleaner exceptions

5437f8a

instruct userlib staging

7f76aca

undo experimental KadaiTaskListener changes

7e5ed00

bruderj15 requested review from gitgoodjhe and leantios June 17, 2026 13:18

Uh oh!

Conversation

bruderj15 commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Definition of Done

Uh oh!

sonarqubecloud Bot commented Mar 20, 2026

Quality Gate failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bruderj15 Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leantios left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 17, 2026

Quality Gate failed

Uh oh!

leantios commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bruderj15 commented Mar 18, 2026 •

edited

Loading

bruderj15 Jun 16, 2026 •

edited

Loading