Open
Conversation
Expand the readme a bit (especially parameter help) and fix a couple of small typos
kadamski
reviewed
Jun 11, 2017
| - `scl_od` (bool, default 0) - SCL is configured as open drain* | ||
| - `scl_oo` (bool, default 0) - SCL output drivers cannot be turned of (no clock stretching) | ||
|
|
||
| *Note that true open drain mode is not supported on RaspberyPi so please only use sxx_od=0 for open drain emulation |
Owner
There was a problem hiding this comment.
I don't really like this comment as it's not general (focuses on RaspberryPi). Most of the boards/SoCs also do not support open drain mode directly but you can still use external logic to enable that. Some more general description would be better, possibly with a link to an "Open Drain and Open Source" section of Documentation/gpio/gpio.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the readme a bit (especially parameter help) and fix a couple of small typos