This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Stop double- encoding and decoding in the mempool #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, when we fetch a tx from a remote mempool, we decode it, then re-encode it to insert it in the local mempool. This deletes the re-encoding. Prior, when we send a tx to a remote mempool, we decode it, deepseq it, then encode the decoded tx to send to the remote mempool. This deletes the deepseq and the re-decoding. This is probably a big deal. Prior, when a tx was inserted into the local mempool via the mempool insert endpoint, we would decode it in the handler, then re-encode it to insert it in the local mempool. This deletes the re-encoding. Change-Id: Id0000000adb067b5766554c94d8188a2b804cd9b
chessai
approved these changes
Feb 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior, when we fetch a tx from a remote mempool, we decode it, then re-encode it to insert it in the local mempool. This deletes the re-encoding.
Prior, when we send a tx to a remote mempool, we decode it, deepseq it, then encode the decoded tx to send to the remote mempool. This deletes the deepseq and the re-decoding. This is probably a big deal.
Prior, when a tx was inserted into the local mempool via the mempool insert endpoint, we would decode it in the handler, then re-encode it to insert it in the local mempool. This deletes the re-encoding.
Change-Id: Id0000000adb067b5766554c94d8188a2b804cd9b