-
Notifications
You must be signed in to change notification settings - Fork 3
Add nginx #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add nginx #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Can you update the README and the ports output in ./network
to include these endpoints?
Also, should we stop exporting ports of the EVMs on the host? In that case we would have to fix the hardhat and blockscout configurations to talk to the proxy.
@larskuhtz I'd recommend to keep exporting the ports for now, as the endpoints are exposed as: http://localhost:8888/devnet1/ and http://localhost:8888/devnet2/ which is slightly different as usual. As I don't know enough of the dev env/toolings available and if they support a different base url, I'd keep exposing the ports. |
I wonder about the URL path names. In the service API in chainweb-node we actually use If we wanted to merge it with the service API of chainweb-node we could use look something like:
With that we would expose all user-facing blockchain HTTP APIs from a single port. |
I think, it is also fine to merge this PR as it is and discuss the API design details later in followup PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it would be nice to use a single proxy for the RPCs of the EVMs as well as chainweb-node. In the case the EVM RPCs should probably be exposed at something like
/chainweb/0.0/evm-development/chain/{CHAIN}/rpc
But that can also be done in a followup PR.
@EnoF do we still need to keep this PR open? |
No description provided.