fix local server issue. closes #347 #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcardon
reviewed
Mar 24, 2025
| @@ -136,6 +136,17 @@ tests = withResource | |||
| assertStatus 200 res | |||
| let (Just (LocalResponse cmdResult)) :: Maybe LocalResponse = A.decodeStrict $ LBS.toStrict reqResp | |||
| liftIO $ assertEqual "Result match expected output" (PactResultOk $ PInteger 3) (_crResult cmdResult) | |||
|
|
|||
| , mkTestCase env "regression #347 (tx validated on local, rejected on send)" $ do | |||
There was a problem hiding this comment.
Could you add a few test cases that local doesn't modify the DB? So a few off the top of my head:
- Sending a command in local then a command in send (Allowed, should be same command)
- Sending the same local request twice (Should be allowed)
- Sending a local request that would manipulate state, and ensure it does not (Try incrementing some module-stored counter and check that the result is the same in two subsequent transactions)
- Sending a command then sending it again in local (this should not be allowed)
| StoreMsg rk cmd result -> _histDbRead (_srHistoryDb env) rk >>= \case | ||
| Nothing -> _histDbInsert (_srHistoryDb env) rk cmd >>= \case | ||
| Right _ -> putMVar result PESuccess | ||
| Left e -> putMVar result (PEUnknownException e) | ||
| Right _ -> putMVar result PESuccess |
There was a problem hiding this comment.
I'm not usually nitpicking on style, but why is the indent so much more dramatic here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
Additionally, please justify why you should or should not do the following: