Expanded example for env-sigs #358
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsgunnlsgunn
requested review from
jmcardon,
rsoeldner and
edmundnoble
as code owners
rsoeldner
reviewed
Mar 27, 2025
docs/builtins/Repl/env-sigs.md
Outdated
| The following example illustrates using the `env-sigs` function to sign a transaction with a specific public key and capability in the Pact REPL: | ||
|
|
||
| ```pact | ||
| (env-sigs [{"key": "9a23bf6a61f753d3ffa45c02b33c65b9dc80b8fb63857debcfe21fdb170fcd99", "caps": [PAYADMIN]}]) |
There was a problem hiding this comment.
IMO this hasn't been tested and is incorrect.
Caps must be enclosed in ()
There was a problem hiding this comment.
Thanks for the help, @CryptoPascal31 !
I know there are some other typos or untested examples, so please do feel free to flag anything you find or submit a fix directly.
There was a problem hiding this comment.
Not only typos... The current Pact 5 documentation has a lot of misleading (and even some totally wrong) statements on every page...
jmcardon
reviewed
Apr 24, 2025
docs/builtins/Repl/env-sigs.md
Outdated
Comment on lines
56
to
58
| ,'caps: [(MINT (read-msg "token-id") (read-string 'account) 4.0)]} | ||
| ]) |
There was a problem hiding this comment.
"key" and "caps" here as well please :)
jmcardon
reviewed
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
Additionally, please justify why you should or should not do the following: