Skip to content

Fix recursion check in direct style interpreter #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix recursion check in direct style interpreter #368

wants to merge 1 commit into from

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented May 9, 2025

Thanks @ggobugi27 for finding this bug

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

rsoeldner
rsoeldner approved these changes May 11, 2025
View reviewed changes
@jmcardon jmcardon force-pushed the jose/fix-repl-recursion branch from f1363ec to a142ab2 Compare May 13, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsoeldner rsoeldner rsoeldner approved these changes

@edmundnoble edmundnoble Awaiting requested review from edmundnoble edmundnoble is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcardon @rsoeldner