WIP: add telemetry - #512
Open
spencerdcarlson wants to merge 3 commits into
Open
Conversation
zmstone
reviewed
Jul 8, 2022
| , {telemetry, "~> 1.0"} | ||
| ]}, | ||
| {erl_opts, [warnings_as_errors, {d, build_brod_cli}]} | ||
| {erl_opts, [warnings_as_errors, {d, build_brod_cli}, {d, brod_use_telemetry}]} |
Contributor
There was a problem hiding this comment.
I'm convinced this is not necessary.
Please remove it.
Contributor
|
Thanks for the PR. BTW. I originally wanted a solution without |
Contributor
|
I have changed the base to |
|
This would be very nice to have. What is needed to get this in? |
|
👋 Also looking to help push this forward, @zmstone , how can I help? |
Contributor
|
Use dependency injection. |
zachallaun
added a commit
to zachallaun/brod
that referenced
this pull request
Aug 14, 2026
Add a dependency on the telemetry library and a brod_metrics module confining all telemetry calls, based on the pattern established in [kafka4beam/wolff](https://github.com/kafka4beam/wolff/blob/4feffa6534a960377507fb2dc840db07548b2533/src/wolff_metrics.erl). The first event, `[brod, product_request_sent]`, is emitted by brod_producer for every produce request successfully sent on the wire. This makes the actual wire-level batching observable, which is otherwise invisible to callers More events can be added to brod_metrics incrementally. Related: kafka4beam#503, kafka4beam#512
zachallaun
added a commit
to zachallaun/brod
that referenced
this pull request
Aug 14, 2026
Add a dependency on the telemetry library and a brod_metrics module confining all telemetry calls, based on the pattern established in [kafka4beam/wolff](https://github.com/kafka4beam/wolff/blob/4feffa6534a960377507fb2dc840db07548b2533/src/wolff_metrics.erl). The first event, `[brod, product_request_sent]`, is emitted by brod_producer for every produce request successfully sent on the wire. This makes the actual wire-level batching observable, which is otherwise invisible to callers More events can be added to brod_metrics incrementally. Related: kafka4beam#503, kafka4beam#512
zachallaun
added a commit
to zachallaun/brod
that referenced
this pull request
Aug 18, 2026
Add a dependency on the telemetry library and a brod_metrics module confining all telemetry calls, based on the pattern established in [kafka4beam/wolff](https://github.com/kafka4beam/wolff/blob/4feffa6534a960377507fb2dc840db07548b2533/src/wolff_metrics.erl). The first event, `[brod, product_request_sent]`, is emitted by brod_producer for every produce request successfully sent on the wire. This makes the actual wire-level batching observable, which is otherwise invisible to callers More events can be added to brod_metrics incrementally. Related: kafka4beam#503, kafka4beam#512
zachallaun
added a commit
to zachallaun/brod
that referenced
this pull request
Aug 18, 2026
Add a dependency on the telemetry library and a brod_metrics module confining all telemetry calls, based on the pattern established in [kafka4beam/wolff](https://github.com/kafka4beam/wolff/blob/4feffa6534a960377507fb2dc840db07548b2533/src/wolff_metrics.erl). The first event, `[brod, product_request_sent]`, is emitted by brod_producer for every produce request successfully sent on the wire. This makes the actual wire-level batching observable, which is otherwise invisible to callers More events can be added to brod_metrics incrementally. Related: kafka4beam#503, kafka4beam#512
zmstone
pushed a commit
that referenced
this pull request
Aug 18, 2026
* Depend on telemetry and emit produce request event Add a dependency on the telemetry library and a brod_metrics module confining all telemetry calls, based on the pattern established in [kafka4beam/wolff](https://github.com/kafka4beam/wolff/blob/4feffa6534a960377507fb2dc840db07548b2533/src/wolff_metrics.erl). The first event, `[brod, product_request_sent]`, is emitted by brod_producer for every produce request successfully sent on the wire. This makes the actual wire-level batching observable, which is otherwise invisible to callers More events can be added to brod_metrics incrementally. Related: #503, #512 * Address code review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.