fix(client): break brod_client <-> producers_sup deadlock - #665
Merged
zmstone merged 2 commits intoJun 13, 2026
Merged
Conversation
zmstone
force-pushed
the
260611-fix-client-producers-sup-deadlock
branch
from
June 11, 2026 14:55
62af618 to
cbb72fc
Compare
thalesmg
reviewed
Jun 11, 2026
Comment on lines
+184
to
+185
| %% Fall back to the synchronous brod_client API on cache miss to preserve | ||
| %% behaviour for any external caller of `start_producer/4'. |
Contributor
There was a problem hiding this comment.
not sure I understand this remark and fallback.
could you please expand on it? i.e., how would this affect an external caller if it starts a child the normal way, in which case it is supposed to hit the cache according to the comment?
Contributor
Author
There was a problem hiding this comment.
the new commit refined this comment.
thalesmg
approved these changes
Jun 11, 2026
…ires Spell out that the cache lookup is guaranteed to hit on every brod_client-driven path (validate_topic_existence/3 populates the entry, and positive entries have no TTL/eviction), so the synchronous fallback is only reached by external callers of start_producer/4 — who retain the pre-fix deadlock risk against a concurrent brod_client metadata refresh.
zmstone
force-pushed
the
260611-fix-client-producers-sup-deadlock
branch
from
June 11, 2026 19:15
749aa00 to
e76a400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #662