fix: reconnect when leader connection recently lost - #115
Merged
zmstone merged 1 commit intoMar 20, 2026
Conversation
When a leader connection is killed (e.g. by Kafka's idle connection timeout) right after a metadata refresh, subsequent get_leader_connections calls would skip reconnection because the metadata timestamp was still fresh. This could result in stale dead connections being returned to health checks until the next metadata refresh cycle. Disconnected connections now carry a timestamp so that ensure_leader_connections can detect recent disconnects per topic and bypass the metadata freshness cache when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a leader connection is killed (e.g. by Kafka's idle connection timeout) right after a metadata refresh, subsequent
get_leader_connectionscalls would skip reconnection because the metadata timestamp was still fresh. This could result in stale dead connections being returned to health checks until the next metadata refresh cycle.Disconnected connections now carry a timestamp so that
ensure_leader_connectionscan detect recent disconnects per topic and bypass the metadata freshness cache when needed.