fix: add missing drop-reason atoms to offset_reply() spec - #121
Merged
Conversation
The offset_reply() type was missing atoms which eval_ack_cb can deliver to ack callbacks and send_sync callers: - partition_lost: on partition loss (producer terminate) - message_expired: max_batch_age drops (new in 4.2.0) - max_retry_exceeded: max_retry drops (new in 4.2.0) The stale spec makes dialyzer reject downstream code matching on these atoms. No behavior change.
thalesmg
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wolff:offset_reply()type spec was stale — it listed onlybuffer_overflow_discardedandmessage_too_large, buteval_ack_cbcan deliver three more reason atoms to ack callbacks andsend_synccallers:partition_lost— producer terminating on partition loss (reply_error_for_all_reqs)message_expired—max_batch_agedrops (new in 4.2.0)max_retry_exceeded—max_retrydrops (new in 4.2.0)The stale spec makes dialyzer reject downstream code that matches on these atoms in a
wolff:send_sync/ack-callback result.Also documented each reason atom on the type, and noted that the offset can be
-1whenrequired_acksisnone(fitskpro:offset()=int64(), so no spec change needed there).No behavior change — spec and docs only. Intended for a 4.2.1 patch release.