feat(ui): surface app-connection envMappings in Configure Agent dialog#282
Merged
feat(ui): surface app-connection envMappings in Configure Agent dialog#282
Conversation
When a user granted an app connection (GitHub, Google, etc.), there was no indication in the dialog that doing so would inject env vars into the agent pod — only granted *secrets* contributed to the "Inherited" list, and app rows didn't show their declared env names at all. Users had to exec into the pod to discover the contract. - ConnectionsPicker: app rows now render their declared env names under the label, matching how secret rows display them. - EditAgentSecretsDialog: granted-app envMappings flow into the Environment tab's "Inherited · managed elsewhere" list, deduped against user-edited entries so the "Custom" override path still wins. Depends on kagenti/onecli#18 — once that ships, every app connection returns a non-null envMappings array and the UI lights up for all of them (not just Google Workspace). Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
969ef9b to
eba7ba1
Compare
matoushavlena
approved these changes
Apr 22, 2026
Contributor
matoushavlena
left a comment
There was a problem hiding this comment.
I know it doesn't directnly depends on the oneCLI PR, but still it would be good to bump the onecli version in helm.
Ships the required envMappings for every app — GitHub, GitHub Enterprise, YouTube, Resend, Spotify — so the Configure Agent dialog now surfaces env info for every connection, not just Google Workspace. Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Granting an app connection (GitHub, Google Drive, etc.) in the Configure Agent dialog silently injects env vars into the agent pod, but the dialog never said so:
Users had to
kubectl execinto a pod to discover what env the agent would see.Changes
ConnectionsPicker: each app row now renders its declared env names (env: FOO, BAR) under the label — same affordance secret rows already have.EditAgentSecretsDialog: granted-app envMappings contribute to the Environment tab's "Inherited" list alongside granted-secret envs. Entries already present in the user's editable list are skipped so the "Custom" override path still wins.Both paths read from
AppConnectionView.envMappings, which the API server passes through verbatim from OneCLI's app registry — no per-provider code in Humr.Depends on
kagenti/onecli#18 — makes
envMappingsrequired on every app definition and populates it for GitHub, GitHub Enterprise, YouTube, Resend, and Spotify. Until that ships, this UI correctly shows env info for Google Workspace only (the one family that currently declares a mapping). After it ships, every connection lights up automatically.Test plan
mise run check(lint + types + Go vet/build + helm lint/render)mise run test(60 Go + 41 TS passing)env: GH_TOKENon the app row and an "Inherited" row on the Environment tabGOOGLE_WORKSPACE_CLI_TOKENappears in both places