Conversation
github-project-automation
Bot
moved this from Backlog
to Done
in Kagenti Issue Prioritization
matoushavlena
added a commit
to kagenti/humr
that referenced
this pull request
Apr 21, 2026
Slimmed the ADR from 143 lines to 43 — kept the decision, dropped implementation detail (zod schemas, Prisma columns, key files, verification blocks) that belongs in commit messages and PRs. Unified the secret + connection paths under one principle: "the entity that owns the credential declares which env vars it needs." The two paths differ in storage (secret metadata vs OneCLI app registry) and flow (controller-merged vs UI-populated) but share the rationale. Captures the four guiding constraints: users shouldn't know env names; Humr shouldn't decide env names for OneCLI-owned providers; templates shouldn't bake connection envs; power users can still tweak per-agent. Tracked in kagenti/onecli#9 (secrets), kagenti/onecli#16 + #262 (connections). Signed-off-by: Matous Havlena <havlenma@gmail.com>
matoushavlena
added a commit
to kagenti/humr
that referenced
this pull request
Apr 21, 2026
Slimmed the ADR from 143 lines to 43 — kept the decision, dropped implementation detail (zod schemas, Prisma columns, key files, verification blocks) that belongs in commit messages and PRs. Unified the secret + connection paths under one principle: "the entity that owns the credential declares which env vars it needs." The two paths differ in storage (secret metadata vs OneCLI app registry) and flow (controller-merged vs UI-populated) but share the rationale. Captures the four guiding constraints: users shouldn't know env names; Humr shouldn't decide env names for OneCLI-owned providers; templates shouldn't bake connection envs; power users can still tweak per-agent. Tracked in kagenti/onecli#9 (secrets), kagenti/onecli#16 + #262 (connections). Signed-off-by: Matous Havlena <havlenma@gmail.com>
matoushavlena
added a commit
to kagenti/humr
that referenced
this pull request
Apr 22, 2026
Slimmed the ADR from 143 lines to 43 — kept the decision, dropped implementation detail (zod schemas, Prisma columns, key files, verification blocks) that belongs in commit messages and PRs. Unified the secret + connection paths under one principle: "the entity that owns the credential declares which env vars it needs." The two paths differ in storage (secret metadata vs OneCLI app registry) and flow (controller-merged vs UI-populated) but share the rationale. Captures the four guiding constraints: users shouldn't know env names; Humr shouldn't decide env names for OneCLI-owned providers; templates shouldn't bake connection envs; power users can still tweak per-agent. Tracked in kagenti/onecli#9 (secrets), kagenti/onecli#16 + #262 (connections). Signed-off-by: Matous Havlena <havlenma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Allow extending metadata (unblocks kagenti/humr#150)
What is the current behavior?
The system strips unknown fields.