feat: spring boot 4 starter #771
Conversation
|
Weird tried temurin 21 also and it's working |
| <relativePath>../pom.xml</relativePath> | ||
| </parent> | ||
|
|
||
| <artifactId>db-scheduler-spring-boot-test-support</artifactId> |
There was a problem hiding this comment.
I appreciate the effort, but not sure it is worth it to extract these classes to a separate module rather than duplicating them. I feel it is more important for the main sources
|
Hey guys, any progress on that? :) PS: Nice Lib @kagkarlsson ! |
pom.xml
Outdated
| <slf4j.version>1.7.36</slf4j.version> | ||
| <logback.version>1.2.13</logback.version> | ||
| <spring-boot.version>3.5.5</spring-boot.version> | ||
| <spring-boot-4.version>4.0.0-RC1</spring-boot-4.version> |
| */ | ||
| @ActiveProfiles("integration-test") | ||
| @Sql(scripts = "classpath:schema.sql") | ||
| class DbSchedulerAutoConfigurationTest { |
There was a problem hiding this comment.
It is a much easier review/merge if we change as little as possible of sb3 code, including tests. Was there a reason we had to rewrite this for sb3?
|
Thanks to everyone for your feedback. Removed SB3 tests refactoring Some code (especially some test conde config) need special attention, not sure about it |
|
@kagkarlsson did you have time to check on that ? |
|
Partly.. trying to port JacksonSerialization to jackson3 for the boot4-starter |
|
Tried to push to your fork, but failed. Usually works, maybe try giving me write permission for the repo? |
|
Would you do a quick review of the changes I pushed @jlafourc ? |
...va/com/github/kagkarlsson/scheduler/boot/autoconfigure/DbSchedulerAutoConfigurationTest.java
Show resolved
Hide resolved
|
Thanks ! |
|
🎉 This issue has been resolved in |
4 participants
Summary
Reminders
mvn spotless:applycc @kagkarlsson