Make ReadAhead related const into optional arguments. #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kahing Please take a look at this PR. Thanks. |
|
could you explain why you want these? |
|
@kahing Thanks for your reply. This PR aimed to supply a way to custom the readAhead chunkSize and readAhead maxSize. For some higher performance request case, we want to read ahead more data, so we want customized the readAhead chunkSize and readAhead maxSize. |
|
Hi @kahing , how about your idea? We use this feature in our product env for months, it can helps us to customize the readAhead chunkSize and readAhead maxSize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.