Skip to content

Do not try to get xattrs for the root inode #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not try to get xattrs for the root inode #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions internal/goofys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ import (
"github.com/jacobsa/fuse/fuseops"
"github.com/jacobsa/fuse/fuseutil"

"github.com/sirupsen/logrus"
"net/http"

"github.com/sirupsen/logrus"
)

// goofys is a Filey System written in Go. All the backend data is
Expand Down Expand Up @@ -464,11 +465,17 @@ func (fs *Goofys) GetXattr(ctx context.Context,

func (fs *Goofys) ListXattr(ctx context.Context,
op *fuseops.ListXattrOp) (err error) {
var xattrs []string

fs.mu.RLock()
inode := fs.getInodeOrDie(op.Inode)
fs.mu.RUnlock()

xattrs, err := inode.ListXattr()
// Do not try to get xattrs for the root inode
// Otherwise the path in the S3 request is empty, which is invalid
if inode.Id != 1 {
xattrs, err = inode.ListXattr()
}

ncopied := 0

Expand Down