For/takepepe#11
Open
kahirokunn wants to merge 4 commits into
Open
Conversation
|
✨✨ That's perfect, there is no visual difference! ✨✨ You can check the report out here. |
| @@ -0,0 +1,4 @@ | |||
| declare module 'pring' { | |||
There was a problem hiding this comment.
ファイル先頭に import * as Pring from 'pring' を追加すれば、既存定義を壊さず重複していないメソッドを生やすことは出来ますね。ただ、initialize がオーバーロード出来ずで、ぐぐっても解決策なさそうで積みました
Owner
Author
There was a problem hiding this comment.
へーーーーーーーーー！
d.tdはモジュールテンプレートファイル？っていうんですかね！
モジュールテンプレートファイルの先頭でimportすると拡張って感じですかね！
kahirokunn
force-pushed
the
master
branch
3 times, most recently
from
ec7e690 to
5cae5f6
Compare
kahirokunn
force-pushed
the
master
branch
10 times, most recently
from
2c7a41b to
1c84825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c8ba44c
こんな感じにpringのinitializeだけ型を変更したいです。しかしこの書き方だとpring moduleには他にも沢山のメソッドとかエクスポートしてるんですが、それらがいない子になってしまう。
ゴール: initializeだけ型を変えるのに成功する