Fix committing on Windows, and folders with space in path #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with paths that have spaces in them, and all Windows paths. Fixes kahole#340
spookylukey
force-pushed
the
fix/340-quote-instance-path
branch
from
733f24a to
d2a5ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #340, when on Windows, attempting to commit (
c c) opens up additional tabs in VS Code, which must be closed first, before theCOMMIT_EDITMSGtab will work. If you just ignore these extra tabs and useCOMMIT_EDITMSG, committing fails silently (which is quite annoying as the commit message you typed is lost).For example, if the current project is in
C:\Users\luke\devel\edamagittest(no space), then attempting to commit produces this:If the path has a space in it, like
C:\Users\luke\devel\edamagit test, then you get further additional tabs, like this:I have seen the bug on multiple Windows machines (at least 3). This bug also affects other platforms if the project folder has a space in it, as noted in the bug report.
This PR fixes it. I have verified that the fix works both for Windows and for Linux.
Fixes #340
Thanks so much for your time, and all your work on edamagit which is awesome. It would be super helpful to the junior members of my team (whom I've got started using edamagit) if this bug fix could be merged and a new release done, thanks!