Skip to content

fix: generate-kind-config.sh for macos - #1318

Merged
itsomri merged 1 commit into
mainfrom
omric/fix-e2e-kind-scripts
Mar 30, 2026
Merged

fix: generate-kind-config.sh for macos#1318
itsomri merged 1 commit into
mainfrom
omric/fix-e2e-kind-scripts

Conversation

@itsomri

@itsomri itsomri commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix an unsupported grep argument on macos

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

Additional Notes

Signed-off-by: itsomri <omric@nvidia.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6aa20dae-a489-4786-b089-c9e0f3a4ef8b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch omric/fix-e2e-kind-scripts

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsomri
itsomri added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit 51af093 Mar 30, 2026
24 checks passed
@itsomri
itsomri deleted the omric/fix-e2e-kind-scripts branch March 30, 2026 07:39
davidLif pushed a commit that referenced this pull request Apr 5, 2026
Signed-off-by: itsomri <omric@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants