fix(scheduler): backport nil-scenario preempt guard to v0.14#1700
Merged
Conversation
…cheduler#1665) (cherry picked from commit fc2b3e2) Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gshaibi
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the
#1665fix for the nil-pointer panic in the preempt scenario builder tov0.14.This resolves the LTS backport request in
#1688by cherry-picking the two nil guards frommain, keeping the focused regression tests, and adding the fix to theCHANGELOG.md[Unreleased]section for the nextv0.14.xrelease.Related Issues
Related to #1664 #1688
Checklist
Breaking Changes
None.
Additional Notes
Validated with:
go test ./pkg/scheduler/actions/common/solvers/...