Skip to content

feat(scheduler): add built-in scenario generators#1744

Merged
enoodle merged 5 commits into
kai-scheduler:mainfrom
enoodle:erez/reclaim-generator-portfolio-05-built-in-generators
Jun 23, 2026
Merged

feat(scheduler): add built-in scenario generators#1744
enoodle merged 5 commits into
kai-scheduler:mainfrom
enoodle:erez/reclaim-generator-portfolio-05-built-in-generators

Conversation

@enoodle

@enoodle enoodle commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Stack slice 5 of 9 for the reclaim generator portfolio.

References:

This PR adds the built-in scenario generator implementations:

  • Adds NodeLocalGreedy.
  • Adds MultiNodeGang.
  • Adds generator tests close to the scenario emission behavior.

Review focus for this slice is the generated scenario shape, scenario quality, and accumulated-filter contract. Portfolio driving is introduced in the next PR.

Related Issues

Related to #1660.

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

None.

Additional Notes

Stacking:

  • Base: erez/reclaim-generator-portfolio-04-wire-budgets
  • Next PR: erez/reclaim-generator-portfolio-06-portfolio-driver

Verification for the rebuilt stack:

  • GOCACHE=/tmp/kai-reclaim-generator-go-cache go test ./pkg/scheduler/plugins/scenariogenerators ./pkg/scheduler/conf_util ./pkg/operator/operands/scheduler ./pkg/scheduler/actions/common/solvers ./pkg/scheduler/actions/reclaim ./pkg/scheduler/actions/preempt ./pkg/scheduler/actions/consolidation ./pkg/scheduler/actions/integration_tests/reclaim ./pkg/scheduler/cache ./pkg/scheduler/cache/status_updater ./pkg/scheduler/metrics ./pkg/apis/scheduling/v2alpha2 -count=1
  • git diff --check
  • GOCACHE=/tmp/kai-reclaim-generator-go-cache make validate

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 57282496-b5ce-4de0-8474-171126f24e44

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 1e5056c to 924e997 Compare June 22, 2026 14:01
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 38a9cec to cf191f2 Compare June 22, 2026 14:04
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 924e997 to 2eb6c36 Compare June 22, 2026 15:19
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch 2 times, most recently from 82f6272 to 18ac836 Compare June 22, 2026 19:48
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 2eb6c36 to 6e28f51 Compare June 22, 2026 19:55
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 18ac836 to 43afdce Compare June 22, 2026 20:50
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 6e28f51 to 7b0d4e6 Compare June 22, 2026 20:51
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 43afdce to ed1504b Compare June 23, 2026 08:59
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 7b0d4e6 to eb3e25c Compare June 23, 2026 09:00
Comment thread pkg/scheduler/actions/common/solvers/node_local_greedy_generator.go Outdated
Comment thread pkg/scheduler/actions/common/solvers/node_local_greedy_generator.go Outdated
Comment thread pkg/scheduler/actions/common/solvers/node_local_greedy_generator.go Outdated
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from ed1504b to 9039001 Compare June 23, 2026 09:33
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from eb3e25c to 23e3426 Compare June 23, 2026 09:33
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 9039001 to 4fc65f5 Compare June 23, 2026 10:01
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 23e3426 to 7de278a Compare June 23, 2026 10:01
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 4fc65f5 to 5282d02 Compare June 23, 2026 10:15
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 7de278a to 21e43a3 Compare June 23, 2026 10:15
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 5282d02 to 0c62055 Compare June 23, 2026 10:46
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 21e43a3 to 0585640 Compare June 23, 2026 10:46
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 0c62055 to e4f1054 Compare June 23, 2026 11:02
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch 2 times, most recently from 4d35dda to f74829e Compare June 23, 2026 11:53
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from e716630 to b2481af Compare June 23, 2026 13:55
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from f74829e to 889360b Compare June 23, 2026 13:55
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from b2481af to 65c5979 Compare June 23, 2026 14:52
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from 889360b to bb5b7d5 Compare June 23, 2026 14:53
enoodle added 2 commits June 23, 2026 20:19
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
enoodle added 3 commits June 23, 2026 20:19
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-04-wire-budgets branch from 65c5979 to 152a0fc Compare June 23, 2026 18:25
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-05-built-in-generators branch from bb5b7d5 to f36d5b0 Compare June 23, 2026 18:25
@enoodle enoodle changed the base branch from erez/reclaim-generator-portfolio-04-wire-budgets to main June 23, 2026 18:25
@enoodle enoodle marked this pull request as ready for review June 23, 2026 18:26
@enoodle enoodle added this pull request to the merge queue Jun 23, 2026
Merged via the queue into kai-scheduler:main with commit 875ce7b Jun 23, 2026
13 checks passed
@enoodle enoodle deleted the erez/reclaim-generator-portfolio-05-built-in-generators branch June 23, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants