feat(scheduler): add built-in scenario generators#1744
Merged
enoodle merged 5 commits intoJun 23, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1e5056c to
924e997
Compare
38a9cec to
cf191f2
Compare
924e997 to
2eb6c36
Compare
82f6272 to
18ac836
Compare
2eb6c36 to
6e28f51
Compare
18ac836 to
43afdce
Compare
6e28f51 to
7b0d4e6
Compare
43afdce to
ed1504b
Compare
7b0d4e6 to
eb3e25c
Compare
davidLif
reviewed
Jun 23, 2026
ed1504b to
9039001
Compare
eb3e25c to
23e3426
Compare
9039001 to
4fc65f5
Compare
23e3426 to
7de278a
Compare
4fc65f5 to
5282d02
Compare
7de278a to
21e43a3
Compare
5282d02 to
0c62055
Compare
21e43a3 to
0585640
Compare
0c62055 to
e4f1054
Compare
4d35dda to
f74829e
Compare
e716630 to
b2481af
Compare
f74829e to
889360b
Compare
b2481af to
65c5979
Compare
889360b to
bb5b7d5
Compare
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
65c5979 to
152a0fc
Compare
bb5b7d5 to
f36d5b0
Compare
davidLif
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack slice 5 of 9 for the reclaim generator portfolio.
References:
docs/developer/designs/reclaim-generator-portfolio-design.md)This PR adds the built-in scenario generator implementations:
NodeLocalGreedy.MultiNodeGang.Review focus for this slice is the generated scenario shape, scenario quality, and accumulated-filter contract. Portfolio driving is introduced in the next PR.
Related Issues
Related to #1660.
Checklist
Breaking Changes
None.
Additional Notes
Stacking:
erez/reclaim-generator-portfolio-04-wire-budgetserez/reclaim-generator-portfolio-06-portfolio-driverVerification for the rebuilt stack:
GOCACHE=/tmp/kai-reclaim-generator-go-cache go test ./pkg/scheduler/plugins/scenariogenerators ./pkg/scheduler/conf_util ./pkg/operator/operands/scheduler ./pkg/scheduler/actions/common/solvers ./pkg/scheduler/actions/reclaim ./pkg/scheduler/actions/preempt ./pkg/scheduler/actions/consolidation ./pkg/scheduler/actions/integration_tests/reclaim ./pkg/scheduler/cache ./pkg/scheduler/cache/status_updater ./pkg/scheduler/metrics ./pkg/apis/scheduling/v2alpha2 -count=1git diff --checkGOCACHE=/tmp/kai-reclaim-generator-go-cache make validate