test(scheduler): add reclaim benchmark and topology coverage#1748
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ee7b007 to
de61e3b
Compare
870035f to
01bc9a1
Compare
de61e3b to
25f257b
Compare
a7cab5b to
79a43cb
Compare
25f257b to
5293483
Compare
79a43cb to
0a374a4
Compare
5293483 to
07c3812
Compare
0a374a4 to
647aadf
Compare
07c3812 to
c14ea56
Compare
647aadf to
281ab40
Compare
c14ea56 to
262ebaf
Compare
281ab40 to
f1b082c
Compare
262ebaf to
91490d6
Compare
f1b082c to
e5dea4a
Compare
91490d6 to
b197399
Compare
e5dea4a to
38a4ded
Compare
b197399 to
d266183
Compare
38a4ded to
a0babdd
Compare
d266183 to
4d54e8c
Compare
| } | ||
| } | ||
|
|
||
| func TestDefaultGeneratorPortfolioPreservesTopologyReclaimCoverage(t *testing.T) { |
There was a problem hiding this comment.
Why put it in the bencghmark test file, and not with the other recliam integration tests?
| benchmarkReclaimLargeJobs(b, 10) | ||
| } | ||
|
|
||
| func TestReclaimLargeJobScenarioSearchBudgetsUsesHalfBudgetForGenerators(t *testing.T) { |
There was a problem hiding this comment.
Why put it in the bencghmark test file, and not with the other recliam integration tests?
a0babdd to
a10b598
Compare
4d54e8c to
03caf61
Compare
a10b598 to
39cb276
Compare
03caf61 to
0d03317
Compare
39cb276 to
f6f1111
Compare
0d03317 to
b3a3368
Compare
f6f1111 to
5ee4e68
Compare
b3a3368 to
5e6c486
Compare
5ee4e68 to
1d78964
Compare
5e6c486 to
6808054
Compare
1d78964 to
bdcbfb9
Compare
6808054 to
1469386
Compare
bdcbfb9 to
e489035
Compare
1469386 to
7d3c6e9
Compare
e489035 to
e1f2adc
Compare
918290a to
87e08e0
Compare
e1f2adc to
122efd6
Compare
06678b1 to
d5e6ed3
Compare
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
d5e6ed3 to
79e14eb
Compare
Description
Stack slice 9 of 9 for the reclaim generator portfolio.
References:
docs/developer/designs/reclaim-generator-portfolio-design.md)This PR adds the benchmark and topology coverage after the production behavior is in place:
This PR is intentionally mostly test/benchmark-only.
Related Issues
Related to #1660.
Checklist
Breaking Changes
None.
Additional Notes
Stacking:
erez/reclaim-generator-portfolio-08-explainabilityVerification for the rebuilt stack:
GOCACHE=/tmp/kai-reclaim-generator-go-cache go test ./pkg/scheduler/plugins/scenariogenerators ./pkg/scheduler/conf_util ./pkg/operator/operands/scheduler ./pkg/scheduler/actions/common/solvers ./pkg/scheduler/actions/reclaim ./pkg/scheduler/actions/preempt ./pkg/scheduler/actions/consolidation ./pkg/scheduler/actions/integration_tests/reclaim ./pkg/scheduler/cache ./pkg/scheduler/cache/status_updater ./pkg/scheduler/metrics ./pkg/apis/scheduling/v2alpha2 -count=1git diff --checkGOCACHE=/tmp/kai-reclaim-generator-go-cache make validate