Skip to content

test(scheduler): add reclaim benchmark and topology coverage#1748

Draft
enoodle wants to merge 3 commits into
kai-scheduler:erez/reclaim-generator-portfolio-08-explainabilityfrom
enoodle:erez/reclaim-generator-portfolio-09-benchmark-topology
Draft

test(scheduler): add reclaim benchmark and topology coverage#1748
enoodle wants to merge 3 commits into
kai-scheduler:erez/reclaim-generator-portfolio-08-explainabilityfrom
enoodle:erez/reclaim-generator-portfolio-09-benchmark-topology

Conversation

@enoodle

@enoodle enoodle commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Stack slice 9 of 9 for the reclaim generator portfolio.

References:

This PR adds the benchmark and topology coverage after the production behavior is in place:

  • Adds/adjusts reclaim benchmark coverage.
  • Includes large-job benchmark flags and assertions.
  • Adds default portfolio topology coverage and related test utility changes.

This PR is intentionally mostly test/benchmark-only.

Related Issues

Related to #1660.

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

None.

Additional Notes

Stacking:

  • Base: erez/reclaim-generator-portfolio-08-explainability
  • Final slice of the split stack.

Verification for the rebuilt stack:

  • GOCACHE=/tmp/kai-reclaim-generator-go-cache go test ./pkg/scheduler/plugins/scenariogenerators ./pkg/scheduler/conf_util ./pkg/operator/operands/scheduler ./pkg/scheduler/actions/common/solvers ./pkg/scheduler/actions/reclaim ./pkg/scheduler/actions/preempt ./pkg/scheduler/actions/consolidation ./pkg/scheduler/actions/integration_tests/reclaim ./pkg/scheduler/cache ./pkg/scheduler/cache/status_updater ./pkg/scheduler/metrics ./pkg/apis/scheduling/v2alpha2 -count=1
  • git diff --check
  • GOCACHE=/tmp/kai-reclaim-generator-go-cache make validate

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 67979509-00f2-46d1-bc18-239c6dddcb6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from ee7b007 to de61e3b Compare June 22, 2026 14:01
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 870035f to 01bc9a1 Compare June 22, 2026 14:04
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from de61e3b to 25f257b Compare June 22, 2026 15:19
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch 2 times, most recently from a7cab5b to 79a43cb Compare June 22, 2026 19:48
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 25f257b to 5293483 Compare June 22, 2026 19:55
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 79a43cb to 0a374a4 Compare June 22, 2026 20:50
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 5293483 to 07c3812 Compare June 22, 2026 20:51
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 0a374a4 to 647aadf Compare June 23, 2026 08:59
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 07c3812 to c14ea56 Compare June 23, 2026 09:00
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 647aadf to 281ab40 Compare June 23, 2026 09:33
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from c14ea56 to 262ebaf Compare June 23, 2026 09:33
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 281ab40 to f1b082c Compare June 23, 2026 10:01
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 262ebaf to 91490d6 Compare June 23, 2026 10:01
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from f1b082c to e5dea4a Compare June 23, 2026 10:15
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 91490d6 to b197399 Compare June 23, 2026 10:15
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from e5dea4a to 38a4ded Compare June 23, 2026 10:46
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from b197399 to d266183 Compare June 23, 2026 10:46
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 38a4ded to a0babdd Compare June 23, 2026 11:02
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from d266183 to 4d54e8c Compare June 23, 2026 11:02
}
}

func TestDefaultGeneratorPortfolioPreservesTopologyReclaimCoverage(t *testing.T) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put it in the bencghmark test file, and not with the other recliam integration tests?

benchmarkReclaimLargeJobs(b, 10)
}

func TestReclaimLargeJobScenarioSearchBudgetsUsesHalfBudgetForGenerators(t *testing.T) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put it in the bencghmark test file, and not with the other recliam integration tests?

@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from a0babdd to a10b598 Compare June 23, 2026 11:53
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 4d54e8c to 03caf61 Compare June 23, 2026 11:53
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from a10b598 to 39cb276 Compare June 23, 2026 14:52
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 03caf61 to 0d03317 Compare June 23, 2026 14:53
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 39cb276 to f6f1111 Compare June 23, 2026 15:17
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 0d03317 to b3a3368 Compare June 23, 2026 15:17
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from f6f1111 to 5ee4e68 Compare June 23, 2026 17:06
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from b3a3368 to 5e6c486 Compare June 23, 2026 17:07
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 5ee4e68 to 1d78964 Compare June 23, 2026 18:38
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 5e6c486 to 6808054 Compare June 23, 2026 18:38
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from 1d78964 to bdcbfb9 Compare June 23, 2026 20:37
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 6808054 to 1469386 Compare June 23, 2026 20:37
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from bdcbfb9 to e489035 Compare June 23, 2026 22:06
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 1469386 to 7d3c6e9 Compare June 23, 2026 22:07
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from e489035 to e1f2adc Compare June 24, 2026 09:42
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from 918290a to 87e08e0 Compare June 24, 2026 09:58
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-08-explainability branch from e1f2adc to 122efd6 Compare June 24, 2026 10:33
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch 4 times, most recently from 06678b1 to d5e6ed3 Compare June 24, 2026 14:51
enoodle added 3 commits June 25, 2026 12:02
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
@enoodle enoodle force-pushed the erez/reclaim-generator-portfolio-09-benchmark-topology branch from d5e6ed3 to 79e14eb Compare June 25, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants