chore(deps): revert k8s.io/* module group to v0.34.x#1753
Open
gshaibi wants to merge 3 commits into
Open
Conversation
Revert the bump in #1472 / #1466. Restore the pre-upgrade dependency baseline: k8s.io/* to v0.34.3 (kube-scheduler v0.34.1), k8s.io/kubernetes to v1.34.2, and sigs.k8s.io/controller-runtime to v0.22.3. Reverts the API adaptations made for the 0.35 upstream: - scheduler framework types sourced from k8s.io/kubernetes/pkg/scheduler/framework again - controller-runtime webhooks back to NewWebhookManagedBy(mgr).For(obj) with runtime.Object casts - DRA feature gate set via featureutil DefaultMutableFeatureGate instead of the process-wide flag Also reverts build-time pins: envtest 1.34.0 / setup-envtest release-0.22 and the default kind tag v1.34.0. Signed-off-by: Guy Shaibi <gshaibi@gmail.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SetDRAFeatureGate returns an error again after the k8s v0.34 revert; handle it at the binder app entrypoint to satisfy errcheck. Signed-off-by: Guy Shaibi <gshaibi@gmail.com>
controller-gen embeds version-dependent godoc from the k8s API types (taint toleration operators, DRA driver vendor docs); revert the CRD manifests to the v0.34 output to satisfy the generated-code drift check. Signed-off-by: Guy Shaibi <gshaibi@gmail.com>
gshaibi
force-pushed
the
shaibi/downgrade-k8s-version-to-0.34.3
branch
from
cd264a9 to
c00dfb8
Compare
📊 Performance Benchmark ResultsComparing PR (
|
|
Total coverage: 52.2% -> 52.2% (delta 0.00%) Merging this branch changes the coverage (2 decrease, 3 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
enoodle
approved these changes
Jun 24, 2026
Collaborator
|
Maybe merge it in a v0.16 branch rather then directly to master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts the Kubernetes dependency bump from #1472 / #1466 back to the proven-good pre-upgrade baseline:
k8s.io/*module group → v0.34.3 (kube-scheduler v0.34.1, others v0.34.1/.2 as before the bump)k8s.io/kubernetes→ v1.34.2sigs.k8s.io/controller-runtime→ v0.22.3The original bump required code adaptations to 0.35 upstream API breakages; this PR reverts those:
k8s.io/kubernetes/pkg/scheduler/frameworkagain (the heavy types —Handle,PreFilterResult,NodeInfoLister, etc. — that don't exist ink8s.io/kube-scheduler/frameworkat v0.34).NewWebhookManagedBy(mgr).For(obj)withruntime.Objecttype-cast boilerplate (no typed generics).featureutil.DefaultMutableFeatureGate(SetFromMap) instead of the process-wideatomic.Boolflag introduced for the GA-locked 1.35 gate. The unrelated NodeResourceTopology feature gate is preserved.Build-time pins reverted as well (hygiene — the ±1 version skew guarantee means these aren't correctness-critical):
1.34.0, setup-envtestrelease-0.22v1.34.0The e2e runtime-compat matrix (1.35/1.36) and
SUPPORT.mdare intentionally left unchanged — KAI still runs against newer clusters.Related Issues
Fixes #
Checklist
Breaking Changes
None.
Additional Notes
Verified locally:
go build ./...,go vet ./...(compiles all test binaries), and unit tests for the affected packages (feature_gates, cache, dynamicresources, predicates, k8s_internal, v2alpha2 webhook) all pass;gofmtclean.