feat(podgrouper): preserve externally-assigned topology constraint#1771
feat(podgrouper): preserve externally-assigned topology constraint#1771noiyemini wants to merge 3 commits into
Conversation
Keep the existing PodGroup topology constraint when the workload does not specify one, so a topology assigned by an external PodGroupAssigner is not overwritten. Workload annotations still take precedence when present. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Total coverage: 52.2% -> 52.3% (delta 0.10%) Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Description
Podgrouper now preserves an existing PodGroup's topology constraint when the workload does not specify one, so a topology assigned outside of KAI is not overwritten on reconcile.
When the workload carries topology annotations, those still take precedence — the externally-assigned constraint is only retained when the incoming PodGroup has an empty
Spec.TopologyConstraint.Topology.Related Issues
Fixes #
Checklist
Breaking Changes
None.
Additional Notes
Added
Test_ignoreFields_TopologyConstraintcovering: workload without topology preserves the external constraint, workload annotations override it, both-empty stays empty, and a topology level without a topology name still preserves the existing constraint.🤖 Generated with Claude Code