feat(binder): Add binder PDB - #2003
Conversation
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@dttung2905 I think you should update here as well: https://github.com/kai-scheduler/KAI-Scheduler/blob/main/pkg/operator/operands/common/common.go#L36-L45 |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
@enoodle nice catch. Thank you for the review. I have updated it as you pointed out. Could you help to review it again? |
|
Total coverage: 54.5% -> 54.4% (delta -0.10%) Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
📝 Changelog fragment recordedThanks! This PR added the changelog fragment(s) below. Pending fragments are folded into |
Description
From this #1477 (comment) by @enoodle , I'm working on adding PDB for binder
Related Issues
#1477
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
Additional Notes