Skip to content

feat(binder): Add binder PDB - #2003

Merged
gshaibi merged 2 commits into
kai-scheduler:mainfrom
dttung2905:add-pdb-binder
Aug 9, 2026
Merged

feat(binder): Add binder PDB#2003
gshaibi merged 2 commits into
kai-scheduler:mainfrom
dttung2905:add-pdb-binder

Conversation

@dttung2905

Copy link
Copy Markdown
Contributor

Description

From this #1477 (comment) by @enoodle , I'm working on adding PDB for binder

Related Issues

#1477

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Added a changelog fragment via make changelog (or applied the skip-changelog label). Do not edit CHANGELOG.md directly — pending fragments are folded into it at release time.

Breaking Changes

Additional Notes

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bedec999-0016-4e0f-b65d-bb9536372de5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@enoodle

enoodle commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@dttung2905 I think you should update here as well: https://github.com/kai-scheduler/KAI-Scheduler/blob/main/pkg/operator/operands/common/common.go#L36-L45

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905

Copy link
Copy Markdown
Contributor Author

@enoodle nice catch. Thank you for the review. I have updated it as you pointed out. Could you help to review it again?

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Total coverage: 54.5% -> 54.4% (delta -0.10%)

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/binder 74.69% (+1.14%) 👍
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/common 78.92% (+0.47%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/binder/binder.go 66.67% (ø) 21 14 7
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/binder/resources.go 75.89% (+1.26%) 141 (+7) 107 (+7) 34 👍
github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/common/common.go 77.56% (+0.49%) 156 (-1) 121 35 (-1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/binder/binder_test.go
  • github.com/kai-scheduler/KAI-scheduler/pkg/operator/operands/common/common_test.go

@gshaibi
gshaibi enabled auto-merge August 9, 2026 10:06
@gshaibi
gshaibi added this pull request to the merge queue Aug 9, 2026
Merged via the queue into kai-scheduler:main with commit 46a09dd Aug 9, 2026
25 of 27 checks passed
@KaiPilotBot

Copy link
Copy Markdown
Collaborator

📝 Changelog fragment recorded

Thanks! This PR added the changelog fragment(s) below. Pending fragments are folded into CHANGELOG.md at release time, so it was intentionally not modified by this PR — your entry will appear in the next release:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants