feat(e2e): Under testing kai hack deployments, Add hami testing option, installing kai-resource-isolator - #2033
Conversation
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
Hello @dttung2905, |
|
Thanks @davidLif . I think both of your points make sense.
I totally agree that
I’ll move the isolator deploy out of |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Sounds good to me. |
|
Total coverage: 54.5% -> 54.5% (delta 0.00%) |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
| set -euo pipefail | ||
|
|
||
| ISOLATOR_CHART_REF="${ISOLATOR_CHART_REF:-oci://docker.io/projecthami/kai-resource-isolator}" | ||
| ISOLATOR_CHART_VERSION="${ISOLATOR_CHART_VERSION:-1.1.0-chart}" |
There was a problem hiding this comment.
chart.yaml on main is still 0.1.0, not 1.1.0-chart. needs a bump after isolator pr 22 merges?
There was a problem hiding this comment.
yes you are right. PR 22 needs to be merged first. I will then update the chart number
| # operators: paired with binder hamicore helm values above. Soft-gated in | ||
| # hamicore e2e when the webhook / monitor are absent. | ||
| if [ "$TEST_HAMI" = "true" ]; then | ||
| ${REPO_ROOT}/hack/hami/deploy_isolator.sh |
There was a problem hiding this comment.
dont see --test-hami wired into ci yet. so hamicore e2e still skips in ci for now, right?
There was a problem hiding this comment.
Yes, I intentionally not wired into CI for now. Wiring them to CI will make the e2e failed because we are running against fake GPU, not real one
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Description
As the final part of this #1821, I'm working on adding e2e test to stand up kai-resource-isolator vgpu monitor to scrape and expose container VRAM metrics
Dependent on Project-HAMi/KAI-resource-isolator#22 to be merged before we can run it on CI
What I ran locally
Then I checked the daemonset
kai-resource-isolator-monitor/metricsendpointsLocal test output
Related Issues
Related to: #1821
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
N/A
Additional Notes