Skip to content

Fix(clusterRole): - Remove ConfigMap access entirely from kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster - #2061

Merged
davidLif merged 2 commits into
kai-scheduler:mainfrom
dttung2905:tighten-cm-verbs-1
Aug 13, 2026
Merged

Fix(clusterRole): - Remove ConfigMap access entirely from kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster#2061
davidLif merged 2 commits into
kai-scheduler:mainfrom
dttung2905:tighten-cm-verbs-1

Conversation

@dttung2905

Copy link
Copy Markdown
Contributor

Description

Remove ConfigMap access entirely from kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster (they never use the ConfigMap API; current full CRUD is leftover leader-election scaffolding). (they never use the ConfigMap API; current full CRUD is leftover leader-election scaffolding).

Related Issues

Fixes #2060

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)
  • Added a changelog fragment via make changelog (or applied the skip-changelog label). Do not edit CHANGELOG.md directly — pending fragments are folded into it at release time.

Breaking Changes

Additional Notes

…pcontroller, podgrouper, queuecontroller, scheduler ClusterRole

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 changed the title Fix(clusterRole): - Remove ConfigMap access entirely from kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster (they never use the ConfigMap API; current full CRUD is leftover leader-election scaffolding). Fix(clusterRole): - Remove ConfigMap access entirely from kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster Aug 11, 2026
@github-actions

Copy link
Copy Markdown

Total coverage: 54.5% -> 54.5% (delta 0.00%)

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/kai-scheduler/KAI-scheduler/cmd/admission/app 0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/cmd/nodescaleadjuster/app 0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/cmd/podgroupcontroller/app 0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/cmd/podgrouper/app 6.41% (ø)
github.com/kai-scheduler/KAI-scheduler/cmd/queuecontroller/app 0.00% (ø)
github.com/kai-scheduler/KAI-scheduler/cmd/scheduler/app 37.86% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/kai-scheduler/KAI-scheduler/cmd/admission/app/app.go 0.00% (ø) 49 0 49
github.com/kai-scheduler/KAI-scheduler/cmd/nodescaleadjuster/app/app.go 0.00% (ø) 33 0 33
github.com/kai-scheduler/KAI-scheduler/cmd/podgroupcontroller/app/app.go 0.00% (ø) 35 0 35
github.com/kai-scheduler/KAI-scheduler/cmd/podgrouper/app/app.go 9.62% (ø) 52 5 47
github.com/kai-scheduler/KAI-scheduler/cmd/queuecontroller/app/app.go 0.00% (ø) 31 0 31
github.com/kai-scheduler/KAI-scheduler/cmd/scheduler/app/server.go 4.71% (ø) 85 4 81

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@gshaibi gshaibi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@davidLif
davidLif added this pull request to the merge queue Aug 13, 2026
Merged via the queue into kai-scheduler:main with commit e73b33d Aug 13, 2026
16 of 19 checks passed
@KaiPilotBot

Copy link
Copy Markdown
Collaborator

📝 Changelog fragment recorded

Thanks! This PR added the changelog fragment(s) below. Pending fragments are folded into CHANGELOG.md at release time, so it was intentionally not modified by this PR — your entry will appear in the next release:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClusterRole: Tighten over-provisioned ConfigMap ClusterRole permissions

4 participants