Fix(clusterRole): - Remove ConfigMap access entirely from kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster - #2061
Merged
Conversation
…pcontroller, podgrouper, queuecontroller, scheduler ClusterRole Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster (they never use the ConfigMap API; current full CRUD is leftover leader-election scaffolding).kai-admission, queuecontroller, kai-podgroup-controller, and kai-node-scale-adjuster
8 tasks
|
Total coverage: 54.5% -> 54.5% (delta 0.00%) Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
davidLif
approved these changes
Aug 13, 2026
Merged
via the queue into
kai-scheduler:main
with commit Aug 13, 2026
e73b33d
16 of 19 checks passed
Collaborator
📝 Changelog fragment recordedThanks! This PR added the changelog fragment(s) below. Pending fragments are folded into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove ConfigMap access entirely from
kai-admission,queuecontroller,kai-podgroup-controller, andkai-node-scale-adjuster(they never use the ConfigMap API; current full CRUD is leftover leader-election scaffolding). (they never use the ConfigMap API; current full CRUD is leftover leader-election scaffolding).Related Issues
Fixes #2060
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
Additional Notes