fix(podgrouper): skip WorkloadRunner wrapper when selecting the grouping plugin - #2070
Open
KaiPilotBot wants to merge 5 commits into
Open
fix(podgrouper): skip WorkloadRunner wrapper when selecting the grouping plugin#2070KaiPilotBot wants to merge 5 commits into
KaiPilotBot wants to merge 5 commits into
Conversation
…ing plugin Wrapping a workload in a run.ai WorkloadRunner adds a level to the owner chain (Pod -> ... -> DynamoGraphDeployment -> WorkloadRunner). Plugin selection keys on the top owner's GVK, and WorkloadRunner had no entry, so every wrapped workload fell through to the default grouper: a single flat PodGroup with minMember 1 and group-wide topology constraints, instead of the per-clique gangs the wrapped kind's plugin would build. Register WorkloadRunner as a skip-top-owner kind, matching the legacy run.ai wrappers. That alone is not enough. skipTopOwnerGrouper resolved the next owner through a raw exact-GVK map lookup, bypassing the hub's wildcard-version fallback and the Karta fallback hub. The DGD is registered with a wildcard version, so a WorkloadRunner -> DGD chain missed and dropped back to the default grouper anyway. Resolve through the hub instead, so a skipped owner picks the same plugin a top owner would. Chained skips are now reachable, so guard the empty owner list that the existing slice arithmetic would panic on. Also add the missing RBAC for dynamographdeployments. Without it the chain walk 403s at the DGD level and silently truncates, which happens to still group correctly via PodCliqueSet but never propagates the DGD's labels and annotations onto the PodGroup. Signed-off-by: gshaibi <gshaibi@nvidia.com> (cherry picked from commit ef66b09)
…osure Both new branches were untested: the len(otherOwners) == 0 fallback in skipTopOwnerGrouper and the closure that resolves a skipped owner through the hub. The hub case exercises the real wiring end to end rather than a stubbed resolver. Signed-off-by: gshaibi <gshaibi@nvidia.com> (cherry picked from commit 7409106)
The recursion always bottoms out at the pod, which resolves to the PodJob grouper rather than back to this one, so the owner list is never exhausted here. Carrying a branch for a state no caller can produce is noise. Signed-off-by: gshaibi <gshaibi@nvidia.com> (cherry picked from commit 3ea43fb)
Signed-off-by: gshaibi <gshaibi@nvidia.com> (cherry picked from commit 9f16afd)
… filled Signed-off-by: gshaibi <gshaibi@nvidia.com> (cherry picked from commit 35b8090)
4 tasks
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2067 to
v0.17.