Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixed-20260815-190234.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixed
body: Render global.daemonsetsTolerations into kai-config
time: 2026-08-15T19:02:34.96721934+01:00
custom:
Author: dttung2905
Issue: ""
4 changes: 4 additions & 0 deletions deployments/kai-scheduler/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ spec:
tolerations:
{{- toYaml .Values.global.tolerations | nindent 6 }}
{{- end }}
{{- if .Values.global.daemonsetsTolerations }}
daemonsetsTolerations:
{{- toYaml .Values.global.daemonsetsTolerations | nindent 6 }}
{{- end }}
{{- if .Values.global.priorityClassName }}
priorityClassName: {{ .Values.global.priorityClassName | quote }}
{{- end }}
Expand Down
42 changes: 42 additions & 0 deletions deployments/kai-scheduler/tests/numa_placement_exporter_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,45 @@ tests:
- equal:
path: spec.numaPlacementExporter.tolerations[0].operator
value: Exists

- it: should not render global.daemonsetsTolerations when the list is empty
asserts:
- notExists:
path: spec.global.daemonsetsTolerations

- it: should render global.daemonsetsTolerations onto spec.global
set:
global.daemonsetsTolerations:
- key: nvidia.com/gpu
operator: Exists
effect: NoSchedule
asserts:
- equal:
path: spec.global.daemonsetsTolerations[0].key
value: nvidia.com/gpu
- equal:
path: spec.global.daemonsetsTolerations[0].operator
value: Exists
- equal:
path: spec.global.daemonsetsTolerations[0].effect
value: NoSchedule

- it: should render global.daemonsetsTolerations independently of exporter tolerations
set:
global.daemonsetsTolerations:
- key: dedicated
operator: Equal
value: gpu
effect: NoSchedule
numaPlacementExporter.tolerations:
- operator: Exists
asserts:
- equal:
path: spec.global.daemonsetsTolerations[0].key
value: dedicated
- equal:
path: spec.global.daemonsetsTolerations[0].value
value: gpu
- equal:
path: spec.numaPlacementExporter.tolerations[0].operator
value: Exists
3 changes: 3 additions & 0 deletions deployments/kai-scheduler/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ global:
affinity: {}
requireDefaultPodAntiAffinityTerm: false
tolerations: []
# Additional tolerations for cluster DaemonSets (e.g. NUMA placement exporter).
# Merged ahead of each DaemonSet's own tolerations by the operator.
daemonsetsTolerations: []
priorityClassName: ""
namespaceLabelSelector: {}
podLabelSelector: {}
Expand Down
Loading