Skip to content

fix(chart): Honor postCleanup.serviceAccountName on the post-delete ServiceAccount - #2079

Open
dttung2905 wants to merge 2 commits into
kai-scheduler:mainfrom
dttung2905:fix-postCleanup-serviceAccountName-rbac-templates
Open

fix(chart): Honor postCleanup.serviceAccountName on the post-delete ServiceAccount#2079
dttung2905 wants to merge 2 commits into
kai-scheduler:mainfrom
dttung2905:fix-postCleanup-serviceAccountName-rbac-templates

Conversation

@dttung2905

Copy link
Copy Markdown
Contributor

Description

postCleanup.serviceAccountName is ignored by SA/RBAC templates although it is mentioned in values.yaml file

postCleanup:
enabled: true
image:
# using crd-upgrader image for kubectl availability
name: crd-upgrader
pullPolicy: IfNotPresent
# tag: "" # Optional: Override global.tag or Chart.AppVersion
serviceAccountName: post-delete-cleanup

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)
  • Added a changelog fragment via make changelog (or applied the skip-changelog label). Do not edit CHANGELOG.md directly — pending fragments are folded into it at release time.

Breaking Changes

Additional Notes

…t, ClusterRole, and ClusterRoleBinding

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Comment thread deployments/kai-scheduler/templates/rbac/post-delete-binding.yaml Outdated
Comment thread deployments/kai-scheduler/templates/rbac/post-delete-clusterrole.yaml Outdated
Comment thread deployments/kai-scheduler/values.yaml Outdated
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 changed the title fix(chart): Honor postCleanup.serviceAccountName on the post-delete ServiceAccount, ClusterRole, and ClusterRoleBinding fix(chart): Honor postCleanup.serviceAccountName on the post-delete ServiceAccount Aug 16, 2026

@gshaibi gshaibi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants