fix(scheduler): Take termination grace period into account for "StuckInReleasing" - #2083
Closed
davidLif wants to merge 4 commits into
Closed
fix(scheduler): Take termination grace period into account for "StuckInReleasing"#2083davidLif wants to merge 4 commits into
davidLif wants to merge 4 commits into
Conversation
…f the pod is still in a terminating state, or is it /StuckInReleasing/ Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
davidLif
enabled auto-merge
August 16, 2026 20:02
davidLif
added
backport v0.9
backport v0.12
backport v0.14
|
Total coverage: 54.6% -> 54.6% (delta 0.00%) Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
📊 Performance Benchmark ResultsComparing PR (
|
Signed-off-by: davidLif <davidshani12@gmail.com>
gshaibi
approved these changes
Aug 17, 2026
gshaibi
requested changes
Aug 17, 2026
gshaibi
left a comment
gshaibi
left a comment
Member
There was a problem hiding this comment.
Wait a minute, I see the upstream already counts the grace period into the deletionTimestamp...
davidLif
disabled auto-merge
August 17, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Take the pod termination grace period into account when determining if the pod is still in a terminating state, or is it "StuckInReleasing"
Related Issues
Fixes #2081
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
Additional Notes