fix(api): allow PodGroup minMember of 0 (v0.9 backport) - #2087
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Backport of 62c594b to v0.9, adapted for non-pointer MinMember and the SubGroups-based scheduler API. Signed-off-by: lin121291 <4jp33f9e@gmail.com> Signed-off-by: gshaibi <gshaibi@nvidia.com>
176160c to
ca9d1c1
Compare
|
Closing: the bug does not exist on v0.9. This branch never had the |
Pull request was closed
Description
Backport of #1989 to
v0.9.Adapted for this branch:
MinMemberhere is a plainint32(not*int32as on main), there is nominSubGroup, and this branch never had aMinimum=1CRD marker (explicitminMember: 0was already accepted by the API but silently clamped to 1 by the scheduler). Changes:minMemberto 1 (max(minMember, 0)instead ofmax(minMember, 1)), so minMember 0 now means no gang requirement (e.g. knative scale-to-zero).make manifests.minSubGroupwebhook/e2e changes from the original PR are dropped (field does not exist on this branch).Note: since
int32withomitemptycannot distinguish an unsetminMemberfrom an explicit 0, a PodGroup created withoutminMembernow gets minAvailable 0 (elastic) instead of the previous implicit 1. Podgrouper-created PodGroups always set it, so this only affects hand-written PodGroups.Same adaptation as the v0.14 (#2085) and v0.12 (#2086) backports.
Related Issues
Backport of #1989.
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
None.
Additional Notes
Unit tests pass for
pkg/scheduler/api/podgroup_infoandpkg/podgrouper/.../knative.