C++: Use unsigned size type for loop index#317
Open
johnbeard wants to merge 1 commit intokaitai-io:masterfrom
Open
C++: Use unsigned size type for loop index#317johnbeard wants to merge 1 commit intokaitai-io:masterfrom
johnbeard wants to merge 1 commit intokaitai-io:masterfrom
Conversation
This avoids a wrong sign conversion when the loop expression casts to a negative signed int. Fixes: kaitai-io/kaitai_struct#1220
Author
|
I figured out adding a test: kaitai-io/kaitai_struct_tests#133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a wrong sign conversion when the loop expression casts to a negative signed int.
Fixes: kaitai-io/kaitai_struct#1220
I did intend to add a test for this based on the reproducing case in the linked issue, but I could not figure out how to actually run the tests.
I tried
build-tests cpp_stlin the tests repo, but it errored out with complaints about Julia(?):How can I build/run the tests? I'll be more than happy to add a test if I know how!