Skip to content

Add parenthesis to overridden functions to silence warnings #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mingun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add parenthesis to overridden functions to silence warnings #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/src/main/scala/io/kaitai/struct/languages/JavaCompiler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ class JavaCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
out.inc
}

override def fetchInstancesFooter: Unit = universalFooter
override def fetchInstancesFooter(): Unit = universalFooter

override def attrInvokeFetchInstances(baseExpr: Ast.expr, exprType: DataType, dataType: DataType): Unit = {
val expr = castIfNeeded(expression(baseExpr), exprType, dataType)
Expand Down
2 changes: 1 addition & 1 deletion shared/src/main/scala/io/kaitai/struct/languages/PythonCompiler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class PythonCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
out.puts("pass")
}

override def fetchInstancesFooter: Unit = universalFooter
override def fetchInstancesFooter(): Unit = universalFooter

override def attrInvokeFetchInstances(baseExpr: Ast.expr, exprType: DataType, dataType: DataType): Unit = {
val expr = expression(baseExpr)
Expand Down
8 changes: 4 additions & 4 deletions shared/src/main/scala/io/kaitai/struct/languages/components/UniversalFooter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ trait UniversalFooter extends LanguageCompiler {

def classFooter(name: String): Unit = universalFooter
def classConstructorFooter: Unit = universalFooter
override def readFooter: Unit = universalFooter
override def writeFooter: Unit = universalFooter
override def writeInstanceFooter: Unit = universalFooter
override def checkInstanceFooter: Unit = universalFooter
override def readFooter(): Unit = universalFooter
override def writeFooter(): Unit = universalFooter
override def writeInstanceFooter(): Unit = universalFooter
override def checkInstanceFooter(): Unit = universalFooter
def condRepeatExprFooter = universalFooter
def condRepeatEosFooter: Unit = universalFooter
override def condRepeatCommonFooter: Unit = universalFooter
Expand Down
Loading