Test#1
Closed
kaitj wants to merge 3 commits into
Closed
Conversation
Requiring python>=3.12 is a bit of a burden. It's only required for `find_bids_datasets`, which uses `Path.walk`. Instead, downgrade minimum python to 3.11 and add a guard on this function in case python<3.12. Note, we could look into downgrading further. The next block would be `get_column_names` returns a `StrEnum`, which was introduced in 3.11. I'm hesitant to remove this though, because being able to treat these enum fields as native strings is nice.
- Enables use of `finds_bids_datasets` in py311. - `root` in `_indexing.py` is initially passed as original type, with walked `dirpath` typecasted as Path - Removed error for <py312 in throughout codebase + testing
kaitj
force-pushed
the
maint/walk
branch
5 times, most recently
from
0d0c3e3 to
1849234
Compare
- Only runs after formatting - Update to dependencies to include other versions of python support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.