Fix gateway and router issues#141
Merged
Merged
Conversation
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
ritazh
commented
Mar 12, 2026
| if (poolCount === 0) { | ||
| return { available: false }; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This fixes the issue that the UI was showing "Not Detected" even when Gateway and InferencePool CRD are installed.
ritazh
commented
Mar 12, 2026
| - list | ||
| - patch | ||
| - update | ||
| - watch |
Contributor
Author
There was a problem hiding this comment.
This is required if we want to auto generate DestinationRules. Otherwise, the cluster operator will need to create them.
Contributor
Author
|
Verified with: curl -m 15 http://<public ip>/v1/chat/completions \
-H "Content-Type: application/json" \
-d '{"model": "microsoft/Phi-3-mini-4k-instruct", "messages": [{"role": "user", "content": "Hello"}]}'
{"choices":[{"finish_reason":"stop","index":0,"logprobs":null,"message":{"content":" Hello!","reasoning_content":null,"role":"assistant","tool_calls":[]},"stop_reason":32007}],"created":1773280441,"id":"chatcmpl-3a77255c-0ccc-49d5-9368-95f8fc2571ec","kv_transfer_params":null,"model":"microsoft/Phi-3-mini-4k-instruct","object":"chat.completion","prompt_logprobs":null,"usage":{"completion_tokens":3,"prompt_tokens":4,"prompt_tokens_details":null,"total_tokens":7}}
curl -m 15 http://<public ip>/v1/chat/completions -H "Content-Type: application/json" -d '{"model": "Qwen/Qwen3-0.6B", "messages": [{"role": "user", "content": "Hello"}]}'
{"choices":[{"finish_reason":"stop","index":0,"logprobs":null,"message":{"content":"\u003cthink\u003e\nOkay, the user just said \"Hello\". I need to respond appropriately. Since the user hasn't asked a specific question, I should acknowledge their greeting. Maybe say \"Hello! How can I assist you today?\" to open the conversation. I should keep it friendly and offer help. Let me check if there's any context I'm missing, but since there isn't, just a simple greeting should work. Make sure the tone is cheerful and helpful.\n\u003c/think\u003e\n\nHello! How can I assist you today? 😊","reasoning_content":null,"role":"assistant","tool_calls":[]},"stop_reason":null}],"created":1773281223,"id":"chatcmpl-73ca65c4-3d69-4bb5-80b3-2656793542fc","kv_transfer_params":null,"model":"Qwen/Qwen3-0.6B","object":"chat.completion","prompt_logprobs":null,"usage":{"completion_tokens":107,"prompt_tokens":9,"prompt_tokens_details":null,"total_tokens":116} |
keithmattix
reviewed
Mar 12, 2026
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
keithmattix
approved these changes
Mar 13, 2026
keithmattix
left a comment
keithmattix
left a comment
Contributor
There was a problem hiding this comment.
LGTM - just have two future looking comments
| // but only if Istio is detected (i.e. the DestinationRule CRD is registered in the cluster). | ||
| // DestinationRule: tell Istio to use SIMPLE TLS (insecureSkipVerify) | ||
| // to skip cert validation. | ||
| func (r *ModelDeploymentReconciler) reconcileEPPDestinationRule(ctx context.Context, md *kubeairunwayv1alpha1.ModelDeployment, eppName string) error { |
Contributor
There was a problem hiding this comment.
Not a blocker for this PR, but we need to figure out if KAIR will continue to auto deploy gateway provider specific solutions like this. Should it deploy and configure the BBR to be used by Istio for example? Definitely an open question
|
|
||
| // restartBBRIfPresent triggers a rolling restart of the body-based-router Deployment (if present | ||
| // in the given namespace) by updating its restart annotation. This is necessary because BBR builds | ||
| // its internal model registry on startup and does not dynamically watch InferencePools. |
Contributor
There was a problem hiding this comment.
Can we file an issue in GAIE for this? That feels like the right place to solve this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AI Prompt (Optional)
🤖 AI Prompt Used
AI Tool:
Type of Change
Related Issues
Changes Made
Testing
bun run test)Checklist
bun run lintScreenshots
Additional Notes