feat(kaito): add setup-kaito target to install KAITO operator#306
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a version-pinned, one-command install/uninstall flow for the KAITO workspace operator (Helm chart) via make -C providers/kaito setup-kaito, aligning KAITO provider setup with the repository’s existing version-drift guard approach (versions.env + generated TS).
Changes:
- Add
KAITO_VERSION=0.10.0toversions.envand regenerateshared/types/versions.generated.ts. - Add
setup-kaito/cleanup-kaitoMake targets inproviders/kaito/Makefilewith a delegatedverify-versionsprerequisite. - Introduce
KAITO_NAMESPACE/KAITO_RELEASE(and intendedKAITO_REPO_URL) knobs for setup customization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
versions.env |
Adds pinned KAITO_VERSION as the repo’s source of truth. |
shared/types/versions.generated.ts |
Regenerates version exports to include KAITO_VERSION. |
providers/kaito/Makefile |
Adds version-guarded setup-kaito / cleanup-kaito Helm install/uninstall targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+25
to
+26
| # KAITO workspace operator Helm chart version (kaito/workspace chart). | ||
| KAITO_VERSION=0.10.0 |
Contributor
Author
There was a problem hiding this comment.
Will address this separately in a new PR.
- Add `setup-kaito` and `cleanup-kaito` Makefile targets that install and uninstall the `kaito/workspace` Helm chart, mirroring the dynamo provider's `setup-dynamo` - Pin `KAITO_VERSION=0.10.0` in `versions.env` as the single source of truth and include it in the kaito Makefile - Regenerate `shared/types/versions.generated.ts` to export `KAITO_VERSION` - Wire up a delegating `verify-versions` target in the kaito Makefile Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
surajssd
force-pushed
the
worktree-setup-kaito
branch
from
3abcded to
ab34042
Compare
- Use `helm repo add --force-update` instead of `2>/dev/null || true` in `providers/kaito/Makefile` so real failures surface and `KAITO_REPO_URL` overrides take effect - Add a `verify-versions` guard in the root `Makefile` asserting the chart `Version` literal in `providers/kaito/config.go` matches `KAITO_VERSION`, making `versions.env` the single source of truth - Extend `hack/test-verify-versions.sh` with a `providers/kaito/config.go` mutation case to protect the new guard from regression Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
- Add a `verify-versions` check (step 5) asserting the `--version` argument in the `providers/kaito/config.go` install `Command` string matches `KAITO_VERSION`, not just the `HelmChart.Version` field, and renumber the generated-TS check to step 6 - Extend `hack/test-verify-versions.sh` with a dedicated mutation case for the install `Command` `--version` arg so the new guard is protected from regression Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
robert-cronin
requested changes
Jun 2, 2026
- Drop redundant `kubectl wait` in `setup-kaito`; rely on helm `--wait --timeout=5m` to block until ready - Scope documented repo refresh to `helm repo update kaito` in `config.go` Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
surajssd
force-pushed
the
worktree-setup-kaito
branch
from
ed1686f to
412471f
Compare
robert-cronin
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a one-command, version-pinned way to install the KAITO workspace operator for the kaito provider, mirroring the dynamo provider's existing
setup-dynamoflow. Previously, installing KAITO required manually copy-pasting a block ofhelm repo add/helm upgrade --install/kubectl waitcommands from a test script. This wires that intomake -C providers/kaito setup-kaito, with the chart version pinned in the repo's single source of truth (versions.env) and guarded against drift bymake verify-versions.Type of Change
Changes Made
setup-kaitoandcleanup-kaitotargets toproviders/kaito/Makefilethat install/uninstall thekaito/workspaceHelm chart, mirroringproviders/dynamo/Makefile'ssetup-dynamo.setup-kaitorunshelm repo add --force-update+helm repo update kaito(idempotent on re-runs), thenhelm upgrade --installwith the same--setflags asproviders/kaito/config.go(featureGates.disableNodeAutoProvisioning=true,nvidiaDevicePlugin.enabled=false,localCSIDriver.useLocalCSIDriver=false,gpu-feature-discovery.gfd.enabled=false,gpu-feature-discovery.nfd.master.deploy=false,gpu-feature-discovery.nfd.worker.deploy=false), and relies onhelm --wait --timeout=5mto block until the operator is ready.KAITO_NAMESPACE,KAITO_RELEASE, andKAITO_REPO_URL(?=so callers can override; defaults to thekaito-workspacenamespace/release).KAITO_VERSION=0.10.0inversions.envas the single source of truth, addedinclude ../../versions.env+exportto the kaito Makefile so the version flows through to--version $(KAITO_VERSION), and regeneratedshared/types/versions.generated.tsto exportKAITO_VERSION.Makefileverify-versionsguard with two KAITO checks: theHelmChart.Versionfield and the installCommand--versionargument inproviders/kaito/config.gomust both matchKAITO_VERSION(renumbered the generated-TS check accordingly). Wired a delegatingverify-versionsprerequisite into the kaito Makefile (guarded byVERIFIED_VERSIONS) sosetup-kaitovalidates version sync before running.hack/test-verify-versions.shwith mutation cases for both new KAITO checks so the drift guard is protected from regression.Testing
bun run test)make verify-versionspasses with the newKAITO_VERSION,make test-verify-versionsconfirms all six drift cases (including both new KAITO mutations) correctly fail, andmake -C providers/kaito setup-kaito -n(dry run) emits the expected, version-pinnedhelmcommands. Not yet run against a live cluster.Checklist
bun run lintAdditional Notes
Makefileverify-versionsguard was added for KAITO: it asserts both theHelmChart.Versionfield and the installCommand--versionargument inproviders/kaito/config.gomatchKAITO_VERSIONfromversions.env, in addition to the regenerated-TS diff check.hack/test-verify-versions.shwas extended with matching mutation cases so the guard is protected from regression.setup-dynamo,setup-kaitointentionally omits the pre-deployment check and GAIE manifest apply — the original KAITO install steps did neither.