Skip to content

chore: Surface error when docker or podman is not installed #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rambohe-ch merged 1 commit into from
May 12, 2026
+15 −1
Merged

chore: Surface error when docker or podman is not installed #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion hack/e2e/scripts/run-e2e-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,20 @@ cleanup() {
exit "${exit_code}"
}

CONTAINER_TOOL="${CONTAINER_TOOL:-$(command -v podman 2>/dev/null || command -v docker 2>/dev/null)}"
CONTAINER_TOOL="${CONTAINER_TOOL:-$(command -v podman 2>/dev/null || command -v docker 2>/dev/null || true)}"

require_container_tool() {
if [[ -z "${CONTAINER_TOOL}" ]]; then
echo "Error: neither 'docker' nor 'podman' found in PATH." >&2
echo "Install Docker (e.g. 'sudo apt-get install docker.io') or set CONTAINER_TOOL." >&2
exit 1
fi
if ! "${CONTAINER_TOOL}" info &>/dev/null; then
echo "Error: '${CONTAINER_TOOL}' is installed but the daemon is not running." >&2
echo "Start it with: sudo systemctl start $(basename "${CONTAINER_TOOL}")" >&2
exit 1
fi
}

# ── Step-level timing ─────────────────────────────────────────────────────
# Tracks wall-clock per top-level do_<step> invocation so we can spot the
Expand Down Expand Up @@ -157,6 +170,7 @@ derive_acr() {
}

do_build_push() {
require_container_tool
derive_acr
echo "=== Building and pushing image to ACR (${ACR_NAME}) ==="
TOKEN=$(az acr login --name "${ACR_NAME}" --expose-token --query accessToken -o tsv)
Expand Down
Loading